Changeset 260502 in webkit


Ignore:
Timestamp:
Apr 21, 2020 9:27:28 PM (4 years ago)
Author:
Devin Rousso
Message:

Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides the navigation sidebar
​https://bugs.webkit.org/show_bug.cgi?id=210838

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel.prototype.canShowRepresentedObject):
Include WI.ShaderProgram in the list of displayable represented objects.

  • UserInterface/Base/Main.js:

(WI.tabContentViewClassForRepresentedObject):

  • UserInterface/Views/GraphicsTabContentView.js:

(WI.GraphicsTabContentView.prototype.canShowRepresentedObject):
Update the list of represented objects that are displayable by the Graphics Tab.

  • UserInterface/Views/GraphicsOverviewContentView.css:

(.content-view.graphics-overview > section > .header):
(.content-view.graphics-overview > section:not(:first-of-type) > .header): Deleted.
Drive-by: add a top border to the first section when overscrolling.

  • UserInterface/Views/CanvasOverviewContentView.css:

(.content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view): Added.
Drive-by: ensure that the "No Preview Available" view doesn't overlap the section header.

Location:
trunk/Source/WebInspectorUI
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r260386 r260502  
     12020-04-21  Devin Rousso  <drousso@apple.com>
     2
     3        Web Inspector: REGRESSION(r255396): Graphics: viewing a shader program hides the navigation sidebar
     4        https://bugs.webkit.org/show_bug.cgi?id=210838
     5
     6        Reviewed by Joseph Pecoraro.
     7
     8        * UserInterface/Views/CanvasSidebarPanel.js:
     9        (WI.CanvasSidebarPanel.prototype.canShowRepresentedObject):
     10        Include `WI.ShaderProgram` in the list of displayable represented objects.
     11
     12        * UserInterface/Base/Main.js:
     13        (WI.tabContentViewClassForRepresentedObject):
     14        * UserInterface/Views/GraphicsTabContentView.js:
     15        (WI.GraphicsTabContentView.prototype.canShowRepresentedObject):
     16        Update the list of represented objects that are displayable by the Graphics Tab.
     17
     18        * UserInterface/Views/GraphicsOverviewContentView.css:
     19        (.content-view.graphics-overview > section > .header):
     20        (.content-view.graphics-overview > section:not(:first-of-type) > .header): Deleted.
     21        Drive-by: add a top border to the first section when overscrolling.
     22
     23        * UserInterface/Views/CanvasOverviewContentView.css:
     24        (.content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view): Added.
     25        Drive-by: ensure that the "No Preview Available" view doesn't overlap the section header.
     26
    1272020-04-20  Devin Rousso  <drousso@apple.com>
    228

  • trunk/Source/WebInspectorUI/UserInterface/Base/Main.js

    r260113 r260502  
    13981398        return WI.AuditTabContentView;
    13991399
    1400     if (representedObject instanceof WI.Canvas || representedObject instanceof WI.ShaderProgram || representedObject instanceof WI.Recording || representedObject instanceof WI.Animation)
     1400    if (representedObject instanceof WI.CanvasCollection
     1401        || representedObject instanceof WI.Canvas
     1402        || representedObject instanceof WI.Recording
     1403        || representedObject instanceof WI.ShaderProgram
     1404        || representedObject instanceof WI.AnimationCollection
     1405        || representedObject instanceof WI.Animation)
    14011406        return WI.GraphicsTabContentView;
    14021407

  • trunk/Source/WebInspectorUI/UserInterface/Views/CanvasOverviewContentView.css

    r256774 r260502  
    145145.content-view.canvas-overview > .content-view.canvas > .preview > .message-text-view {
    146146    position: static;
     147    z-index: 0;
    147148}
    148149

  • trunk/Source/WebInspectorUI/UserInterface/Views/CanvasSidebarPanel.js

    r255396 r260502  
    239239    {
    240240        return representedObject instanceof WI.Canvas
     241            || representedObject instanceof WI.ShaderProgram
    241242            || representedObject instanceof WI.Recording;
    242243    }

  • trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsOverviewContentView.css

    r255396 r260502  
    4444    align-items: center;
    4545    position: sticky;
    46     top: 0;
     46    top: -1px;
    4747    z-index: 1;
    4848    min-height: var(--navigation-bar-height);
     49    margin-top: -1px;
    4950    -webkit-padding-start: 8px;
    5051    background-color: hsl(0, 0%, 97%);
     52    border-top: 1px solid var(--border-color);
    5153    border-bottom: 1px solid var(--border-color);
    52 }
    53 
    54 .content-view.graphics-overview > section:not(:first-of-type) > .header {
    55     border-top: 1px solid var(--border-color);
    5654}
    5755

  • trunk/Source/WebInspectorUI/UserInterface/Views/GraphicsTabContentView.js

    r259101 r260502  
    113113        return representedObject instanceof WI.CanvasCollection
    114114            || representedObject instanceof WI.Canvas
    115             || representedObject instanceof WI.RecordingCollection
    116115            || representedObject instanceof WI.Recording
    117             || representedObject instanceof WI.ShaderProgramCollection
    118116            || representedObject instanceof WI.ShaderProgram
    119117            || representedObject instanceof WI.AnimationCollection
Note: See TracChangeset for help on using the changeset viewer.