Changeset 260610 in webkit

Timestamp:

Apr 23, 2020 5:12:00 PM (4 years ago)

Author:

ysuzuki@apple.com

Message:

Support --report-execution-time to report execution time for each JSC stress test
​https://bugs.webkit.org/show_bug.cgi?id=210938

Reviewed by Saam Barati.

We can run run-javascriptcore-tests with --report-execution-time option to report execution time for each JSC stress test,
to figure out which test is taking a long time. It appends execution-time to the verbose log. To see it stderr, --verbose is also
required.

$ run-javascriptcore-tests .... --verbose --report-execution-time

• Scripts/run-javascriptcore-tests:

(runJSCStressTests):

• Scripts/run-jsc-stress-tests:
• Scripts/webkitruby/jsc-stress-test-writer-default.rb:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-javascriptcore-tests (modified) (4 diffs)
• Scripts/run-jsc-stress-tests (modified) (4 diffs)
• Scripts/webkitruby/jsc-stress-test-writer-default.rb (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-04-23  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Support `--report-execution-time` to report execution time for each JSC stress test
+        https://bugs.webkit.org/show_bug.cgi?id=210938
+
+        Reviewed by Saam Barati.
+
+        We can run `run-javascriptcore-tests` with `--report-execution-time` option to report execution time for each JSC stress test,
+        to figure out which test is taking a long time. It appends execution-time to the verbose log. To see it stderr, --verbose is also
+        required.
+
+        $ run-javascriptcore-tests .... --verbose --report-execution-time
+
+        * Scripts/run-javascriptcore-tests:
+        (runJSCStressTests):
+        * Scripts/run-jsc-stress-tests:
+        * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
+
 2020-04-23  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Tools/Scripts/run-javascriptcore-tests

@@ -63 +63 @@
 my $testWriter;
 my $memoryLimited;
+my $reportExecutionTime;
 
 my $report;
@@ -273 +274 @@
                                 Skip tests tagged with //\@skip if \$memoryLimited
 
+  --report-execution-time       Print execution time for each stress test.
+
   --filter                      Only run tests whose name matches the given regular expression.
   --env-vars                    Pass a list of environment variables to set before running tests.
@@ -335 +338 @@
     'test-writer=s' => \$testWriter,
     'memory-limited' => \$memoryLimited,
+    'report-execution-time' => \$reportExecutionTime,
     'filter=s' => \$filter,
     'help' => \$showHelp,
@@ -788 +792 @@
     }
 
+    if ($reportExecutionTime) {
+        push(@jscStressDriverCmd, "--report-execution-time");
+    }
+
     if ($filter) {
         push(@jscStressDriverCmd, "--filter");

trunk/Tools/Scripts/run-jsc-stress-tests

@@ -122 +122 @@
 $buildType = "release"
 $forceCollectContinuously = false
+$reportExecutionTime = false
 
 def usage
@@ -151 +152 @@
     puts "--remote                    Specify a remote host on which to run tests from command line argument."
     puts "--remote-config-file        Specify a remote host on which to run tests from JSON file."
+    puts "--report-execution-time     Print execution time for each test."
     puts "--child-processes    (-c)   Specify the number of child processes."
     puts "--filter                    Only run tests whose name matches the given regular expression."
@@ -186 +188 @@
                ['--remote', GetoptLong::REQUIRED_ARGUMENT],
                ['--remote-config-file', GetoptLong::REQUIRED_ARGUMENT],
+               ['--report-execution-time', GetoptLong::NO_ARGUMENT],
                ['--model', GetoptLong::REQUIRED_ARGUMENT],
                ['--child-processes', '-c', GetoptLong::REQUIRED_ARGUMENT],
@@ -237 +240 @@
     when '--remote-config-file'
         $remoteConfigFile = arg
+    when '--report-execution-time'
+        $reportExecutionTime = true
     when '--child-processes'
         $numChildProcesses = arg.to_i

trunk/Tools/Scripts/webkitruby/jsc-stress-test-writer-default.rb

@@ -264 +264 @@
     
     def successCommand
-        if $progressMeter or $verbosity >= 2
-            "rm -f #{failFile} ; echo PASS: #{Shellwords.shellescape(@name)}"
+        executionTimeMessage = ""
+        if $reportExecutionTime
+            executionTimeMessage = " $(($SECONDS - $START_TIME))s"
+        end
+        if $progressMeter or $reportExecutionTime or $verbosity >= 2
+            "rm -f #{failFile} ; echo PASS: #{Shellwords.shellescape(@name)}#{executionTimeMessage}"
         else
             "rm -f #{failFile}"
@@ -278 +282 @@
         File.open(filename, "w") {
             | outp |
+            if $reportExecutionTime
+                outp.puts "START_TIME=$SECONDS"
+            end
             outp.puts "echo Running #{Shellwords.shellescape(@name)}"
             cmd  = "(" + shellCommand + " || (echo $? > #{failFile})) 2>&1 "