Changeset 260619 in webkit

Timestamp:

Apr 23, 2020 9:52:59 PM (4 years ago)

Author:

ysuzuki@apple.com

Message:

Make JSCOnly work on macOS
​https://bugs.webkit.org/show_bug.cgi?id=210953

Reviewed by Ross Kirsling.

In JSCOnly port on macOS, we should disable ICU API renaming because OS shipped ICU does not have version suffix.

• Source/cmake/OptionsJSCOnly.cmake:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/OptionsJSCOnly.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2020-04-23  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Make JSCOnly work on macOS
+        https://bugs.webkit.org/show_bug.cgi?id=210953
+
+        Reviewed by Ross Kirsling.
+
+        In JSCOnly port on macOS, we should disable ICU API renaming because OS shipped ICU does not have version suffix.
+
+        * Source/cmake/OptionsJSCOnly.cmake:
+
 2020-04-22  Darin Adler  <darin@apple.com>
 

trunk/Source/cmake/OptionsJSCOnly.cmake

@@ -97 +97 @@
 
 find_package(ICU 60.2 REQUIRED COMPONENTS data i18n uc)
+if (APPLE)
+    add_definitions(-DU_DISABLE_RENAMING=1)
+endif ()