Changeset 260663 in webkit

Timestamp:

Apr 24, 2020 1:05:57 PM (4 years ago)

Author:

timothy_horton@apple.com

Message:

iPad: "Pocket City" interaction does not work with trackpad
​https://bugs.webkit.org/show_bug.cgi?id=210985
<rdar://problem/62273077>

Reviewed by Wenson Hsieh.

Source/WebCore:

• platform/RuntimeApplicationChecks.h:
• platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isPocketCity):

Source/WebKit:

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView shouldUseMouseGestureRecognizer]):
Add another app to the list who fall back to touch event synthesis until rebuilt.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/RuntimeApplicationChecks.h (modified) (1 diff)
• WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-24  Tim Horton  <timothy_horton@apple.com>
+
+        iPad: "Pocket City" interaction does not work with trackpad
+        https://bugs.webkit.org/show_bug.cgi?id=210985
+        <rdar://problem/62273077>
+
+        Reviewed by Wenson Hsieh.
+
+        * platform/RuntimeApplicationChecks.h:
+        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
+        (WebCore::IOSApplication::isPocketCity):
+
 2020-04-24  Tomoki Imai  <Tomoki.Imai@sony.com>
 

trunk/Source/WebCore/platform/RuntimeApplicationChecks.h

@@ -104 +104 @@
 WEBCORE_EXPORT bool isStocks();
 WEBCORE_EXPORT bool isFeedly();
+WEBCORE_EXPORT bool isPocketCity();
 
 } // IOSApplication

trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

@@ -364 +364 @@
 }
 
+bool IOSApplication::isPocketCity()
+{
+    static bool isPocketCity = applicationBundleIsEqualTo("com.codebrewgames.pocketcity"_s);
+    return isPocketCity;
+}
+
 #endif
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-24  Tim Horton  <timothy_horton@apple.com>
+
+        iPad: "Pocket City" interaction does not work with trackpad
+        https://bugs.webkit.org/show_bug.cgi?id=210985
+        <rdar://problem/62273077>
+
+        Reviewed by Wenson Hsieh.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView shouldUseMouseGestureRecognizer]):
+        Add another app to the list who fall back to touch event synthesis until rebuilt.
+
 2020-04-24  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -8403 +8403 @@
             return NO;
 
+        // <rdar://problem/62273077> "Pocket City" does not respond to mouse events, only touch events
+        if (WebCore::IOSApplication::isPocketCity())
+            return NO;
+
         return YES;
     }();