Changeset 260664 in webkit

Timestamp:

Apr 24, 2020 1:11:04 PM (4 years ago)

Author:

ysuzuki@apple.com

Message:

Unreviewed, build fix in Windows
​https://bugs.webkit.org/show_bug.cgi?id=210892

Windows MSVC does not have proper understanding of IGNORE_RETURN_TYPE_WARNINGS_BEGIN.

• runtime/JSBigInt.h:

(JSC::invertBigIntCompareResult):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSBigInt.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-04-24  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Unreviewed, build fix in Windows
+        https://bugs.webkit.org/show_bug.cgi?id=210892
+
+        Windows MSVC does not have proper understanding of IGNORE_RETURN_TYPE_WARNINGS_BEGIN.
+
+        * runtime/JSBigInt.h:
+        (JSC::invertBigIntCompareResult):
+
 2020-04-24  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSBigInt.h

@@ -291 +291 @@
 }
 
-#if !ASSERT_ENABLED
-IGNORE_RETURN_TYPE_WARNINGS_BEGIN
-#endif
 ALWAYS_INLINE JSBigInt::ComparisonResult invertBigIntCompareResult(JSBigInt::ComparisonResult comparisonResult)
 {
@@ -301 +298 @@
     case JSBigInt::ComparisonResult::LessThan:
         return JSBigInt::ComparisonResult::GreaterThan;
-    case JSBigInt::ComparisonResult::Equal:
-    case JSBigInt::ComparisonResult::Undefined:
+    default:
         return comparisonResult;
     }
-    ASSERT_NOT_REACHED();
 }
-#if !ASSERT_ENABLED
-IGNORE_RETURN_TYPE_WARNINGS_END
-#endif
 
 } // namespace JSC