Changeset 260714 in webkit


Ignore:
Timestamp:
Apr 25, 2020 5:31:57 PM (4 years ago)
Author:
ysuzuki@apple.com
Message:

Use static initialized Lock instead of LazyNeverDestroyed<Lock>
​https://bugs.webkit.org/show_bug.cgi?id=211010

Reviewed by Mark Lam.

WTF::Lock can be static-initialized, so no need to use LazyNeverDestroyed<Lock>.

  • Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::instancesMutex):

  • Modules/webgpu/WebGPUPipeline.cpp:

(WebCore::WebGPUPipeline::instancesMutex):

  • html/canvas/CanvasRenderingContext.cpp:

(WebCore::CanvasRenderingContext::instancesMutex):

  • html/canvas/WebGLProgram.cpp:

(WebCore::WebGLProgram::instancesMutex):

Location:
trunk/Source/WebCore
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r260712 r260714  
     12020-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
     2
     3        Use static initialized Lock instead of LazyNeverDestroyed<Lock>
     4        https://bugs.webkit.org/show_bug.cgi?id=211010
     5
     6        Reviewed by Mark Lam.
     7
     8        WTF::Lock can be static-initialized, so no need to use LazyNeverDestroyed<Lock>.
     9
     10        * Modules/webgpu/WebGPUDevice.cpp:
     11        (WebCore::WebGPUDevice::instancesMutex):
     12        * Modules/webgpu/WebGPUPipeline.cpp:
     13        (WebCore::WebGPUPipeline::instancesMutex):
     14        * html/canvas/CanvasRenderingContext.cpp:
     15        (WebCore::CanvasRenderingContext::instancesMutex):
     16        * html/canvas/WebGLProgram.cpp:
     17        (WebCore::WebGLProgram::instancesMutex):
     18
    1192020-04-25  Darin Adler  <darin@apple.com>
    220

  • trunk/Source/WebCore/Modules/webgpu/WebGPUDevice.cpp

    r251425 r260714  
    110110Lock& WebGPUDevice::instancesMutex()
    111111{
    112     static LazyNeverDestroyed<Lock> mutex;
    113     static std::once_flag initializeMutex;
    114     std::call_once(initializeMutex, [] {
    115         mutex.construct();
    116     });
    117     return mutex.get();
     112    static Lock mutex;
     113    return mutex;
    118114}
    119115

  • trunk/Source/WebCore/Modules/webgpu/WebGPUPipeline.cpp

    r251315 r260714  
    4848Lock& WebGPUPipeline::instancesMutex()
    4949{
    50     static LazyNeverDestroyed<Lock> mutex;
    51     static std::once_flag initializeMutex;
    52     std::call_once(initializeMutex, [] {
    53         mutex.construct();
    54     });
    55     return mutex.get();
     50    static Lock mutex;
     51    return mutex;
    5652}
    5753

  • trunk/Source/WebCore/html/canvas/CanvasRenderingContext.cpp

    r251630 r260714  
    5353Lock& CanvasRenderingContext::instancesMutex()
    5454{
    55     static LazyNeverDestroyed<Lock> mutex;
    56     static std::once_flag initializeMutex;
    57     std::call_once(initializeMutex, [] {
    58         mutex.construct();
    59     });
    60     return mutex.get();
     55    static Lock mutex;
     56    return mutex;
    6157}
    6258

  • trunk/Source/WebCore/html/canvas/WebGLProgram.cpp

    r254214 r260714  
    4747Lock& WebGLProgram::instancesMutex()
    4848{
    49     static LazyNeverDestroyed<Lock> mutex;
    50     static std::once_flag initializeMutex;
    51     std::call_once(initializeMutex, [] {
    52         mutex.construct();
    53     });
    54     return mutex.get();
     49    static Lock mutex;
     50    return mutex;
    5551}
    5652
Note: See TracChangeset for help on using the changeset viewer.