Changeset 260731 in webkit

Timestamp:

Apr 26, 2020 2:17:43 PM (4 years ago)

Author:

ysuzuki@apple.com

Message:

Use static Lock instead of static NeverDestroyed<Lock>
​https://bugs.webkit.org/show_bug.cgi?id=211036

Reviewed by Darin Adler.

Source/WebCore:

• platform/GenericTaskQueue.cpp:

(WebCore::TaskDispatcher<Timer>::sharedLock):

Source/WTF:

Lock can be static-initialized since it has constexpr constructor. No need to use NeverDestroyed<Lock>.

• wtf/Logger.h:

(WTF::Logger::observerLock):

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/Logger.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/GenericTaskQueue.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-04-26  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Use `static Lock` instead of `static NeverDestroyed<Lock>`
+        https://bugs.webkit.org/show_bug.cgi?id=211036
+
+        Reviewed by Darin Adler.
+
+        Lock can be static-initialized since it has constexpr constructor. No need to use NeverDestroyed<Lock>.
+
+        * wtf/Logger.h:
+        (WTF::Logger::observerLock):
+
 2020-04-26  Joonghun Park  <jh718.park@samsung.com>
 

trunk/Source/WTF/wtf/Logger.h

@@ -368 +368 @@
     static Lock& observerLock()
     {
-        static NeverDestroyed<Lock> observerLock;
+        static Lock observerLock;
         return observerLock;
     }

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-26  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        Use `static Lock` instead of `static NeverDestroyed<Lock>`
+        https://bugs.webkit.org/show_bug.cgi?id=211036
+
+        Reviewed by Darin Adler.
+
+        * platform/GenericTaskQueue.cpp:
+        (WebCore::TaskDispatcher<Timer>::sharedLock):
+
 2020-04-26  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/platform/GenericTaskQueue.cpp

@@ -64 +64 @@
 Lock& TaskDispatcher<Timer>::sharedLock()
 {
-    static NeverDestroyed<Lock> lock;
+    static Lock lock;
     return lock;
 }