Changeset 260789 in webkit

Timestamp:

Apr 27, 2020 3:08:26 PM (4 years ago)

Author:

dino@apple.com

Message:

getShaderPrecisionFormat returns the wrong values
​https://bugs.webkit.org/show_bug.cgi?id=211013
<rdar://problem/62378056>

Reviewed by Darin Adler.

Gregg pointed out that our code hardcodes values for
getShaderPrecisionFormat. The fix is simply to call into
the underlying GL function.

Covered by the existing test: webgl/1.0.3/conformance/misc/shader-precision-format.html

However, that just tests minimum values. Devices have different
actual results.

• platform/graphics/angle/GraphicsContextGLANGLE.cpp:

(WebCore::GraphicsContextGLOpenGL::getShaderPrecisionFormat):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/angle/GraphicsContextGLANGLE.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-27  Dean Jackson  <dino@apple.com>
+
+        getShaderPrecisionFormat returns the wrong values
+        https://bugs.webkit.org/show_bug.cgi?id=211013
+        <rdar://problem/62378056>
+
+        Reviewed by Darin Adler.
+
+        Gregg pointed out that our code hardcodes values for
+        getShaderPrecisionFormat. The fix is simply to call into
+        the underlying GL function.
+
+        Covered by the existing test: webgl/1.0.3/conformance/misc/shader-precision-format.html
+
+        However, that just tests minimum values. Devices have different
+        actual results.
+
+        * platform/graphics/angle/GraphicsContextGLANGLE.cpp:
+        (WebCore::GraphicsContextGLOpenGL::getShaderPrecisionFormat):
+
 2020-04-27  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/graphics/angle/GraphicsContextGLANGLE.cpp

@@ -312 +312 @@
 void GraphicsContextGLOpenGL::getShaderPrecisionFormat(GCGLenum shaderType, GCGLenum precisionType, GCGLint* range, GCGLint* precision)
 {
-    UNUSED_PARAM(shaderType);
-    ASSERT(range);
-    ASSERT(precision);
-
-    makeContextCurrent();
-
-    switch (precisionType) {
-    case GraphicsContextGL::LOW_INT:
-    case GraphicsContextGL::MEDIUM_INT:
-    case GraphicsContextGL::HIGH_INT:
-        // These values are for a 32-bit twos-complement integer format.
-        range[0] = 31;
-        range[1] = 30;
-        precision[0] = 0;
-        break;
-    case GraphicsContextGL::LOW_FLOAT:
-    case GraphicsContextGL::MEDIUM_FLOAT:
-    case GraphicsContextGL::HIGH_FLOAT:
-        // These values are for an IEEE single-precision floating-point format.
-        range[0] = 127;
-        range[1] = 127;
-        precision[0] = 23;
-        break;
-    default:
-        ASSERT_NOT_REACHED();
-        break;
-    }
+    makeContextCurrent();
+    gl::GetShaderPrecisionFormat(shaderType, precisionType, range, precision);
 }