Changeset 260813 in webkit

Timestamp:

Apr 28, 2020 2:57:41 AM (4 years ago)

Author:

youenn@apple.com

Message:

Ensure remote track event gets unmuted after the track event is fired
​https://bugs.webkit.org/show_bug.cgi?id=211071

Reviewed by Alex Christensen.

This code was made obsolete by the setMuted(false) call done just after firing the track event.
Given the setMuted(false) in addPendingTrackEvent was done asynchronously and was triggering firing the muted event asynchronously,
this change should not be observable from JS.

• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::addPendingTrackEvent):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-04-28  Youenn Fablet  <youenn@apple.com>
+
+        Ensure remote track event gets unmuted after the track event is fired
+        https://bugs.webkit.org/show_bug.cgi?id=211071
+
+        Reviewed by Alex Christensen.
+
+        This code was made obsolete by the setMuted(false) call done just after firing the track event.
+        Given the setMuted(false) in addPendingTrackEvent was done asynchronously and was triggering firing the muted event asynchronously,
+        this change should not be observable from JS.
+
+        * Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:
+        (WebCore::LibWebRTCMediaEndpoint::addPendingTrackEvent):
+
 2020-04-28  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp

@@ -369 +369 @@
 
     m_peerConnectionBackend.addPendingTrackEvent({ WTFMove(receiver), makeRef(track), WTFMove(streams), WTFMove(transceiver) });
-
-    // FIXME: We should unmute tracks when receiving the first packet, for now we simulate this by unmuting asynchronously here.
-    callOnMainThread([source = makeRef(track.source())] {
-        source->setMuted(false);
-    });
 }