Changeset 260822 in webkit


Ignore:
Timestamp:
Apr 28, 2020 7:17:17 AM (4 years ago)
Author:
Philippe Normand
Message:

media/track/track-load-error-readyState.html passes only when accompanied by some other tests
​https://bugs.webkit.org/show_bug.cgi?id=210976

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState): Reset caption
display mode, which might have been overriden by a previous test.

LayoutTests:

  • media/track/track-load-error-readyState-expected.txt:
  • media/track/track-load-error-readyState.html: Ensure the caption

display mode is set to automatic, this is a requirement for the
test.

  • media/track/track-mode-not-changed-by-new-track-expected.txt:
  • media/track/track-mode-not-changed-by-new-track.html: Ditto.
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r260820 r260822  
     12020-04-28  Philippe Normand  <pnormand@igalia.com>
     2
     3        media/track/track-load-error-readyState.html passes only when accompanied by some other tests
     4        https://bugs.webkit.org/show_bug.cgi?id=210976
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        * media/track/track-load-error-readyState-expected.txt:
     9        * media/track/track-load-error-readyState.html: Ensure the caption
     10        display mode is set to automatic, this is a requirement for the
     11        test.
     12        * media/track/track-mode-not-changed-by-new-track-expected.txt:
     13        * media/track/track-mode-not-changed-by-new-track.html: Ditto.
     14
    1152020-04-28  Per Arne Vollan  <pvollan@apple.com>
    216

  • trunk/LayoutTests/media/track/track-load-error-readyState-expected.txt

    r158743 r260822  
    22
    33
     4RUN(internals.setCaptionDisplayMode('Automatic'))
    45EVENT(error)
    56EXPECTED (track.readyState == '3') OK

  • trunk/LayoutTests/media/track/track-load-error-readyState.html

    r102212 r260822  
    77        <script src=../video-test.js></script>
    88        <script>
     9
     10            function setup()
     11            {
     12                if (window.internals)
     13                    run("internals.setCaptionDisplayMode('Automatic')");
     14            }
    915
    1016            function trackError()
    … …  
    1824        </script>
    1925    </head>
    20     <body>
     26    <body onload="setup()">
    2127        <p>Tests the error event on HTMLTrackElement and ERROR readyState on TextTrack.</p>
    2228        <video id="videotests">

  • trunk/LayoutTests/media/track/track-mode-not-changed-by-new-track-expected.txt

    r158743 r260822  
    22
    33
     4RUN(internals.setCaptionDisplayMode('Automatic'))
    45
    56EVENT(load) -- <body>

  • trunk/LayoutTests/media/track/track-mode-not-changed-by-new-track.html

    r135202 r260822  
    7979            function start()
    8080            {
     81                if (window.internals)
     82                    run("internals.setCaptionDisplayMode('Automatic')");
     83
    8184                consoleWrite("<br>EVENT(load) -- &lt;body&gt;");
    8285                findMediaElement();

  • trunk/Source/WebCore/ChangeLog

    r260818 r260822  
     12020-04-28  Philippe Normand  <pnormand@igalia.com>
     2
     3        media/track/track-load-error-readyState.html passes only when accompanied by some other tests
     4        https://bugs.webkit.org/show_bug.cgi?id=210976
     5
     6        Reviewed by Xabier Rodriguez-Calvar.
     7
     8        * testing/Internals.cpp:
     9        (WebCore::Internals::resetToConsistentState): Reset caption
     10        display mode, which might have been overriden by a previous test.
     11
    1122020-04-28  Adrian Perez de Castro  <aperez@igalia.com>
    213

  • trunk/Source/WebCore/testing/Internals.cpp

    r260774 r260822  
    514514#if ENABLE(VIDEO_TRACK)
    515515    page.group().captionPreferences().setTestingMode(true);
     516    page.group().captionPreferences().setCaptionDisplayMode(CaptionUserPreferences::ForcedOnly);
    516517    page.group().captionPreferences().setCaptionsStyleSheetOverride(emptyString());
    517518    page.group().captionPreferences().setTestingMode(false);
Note: See TracChangeset for help on using the changeset viewer.