Changeset 260846 in webkit


Ignore:
Timestamp:
Apr 28, 2020 2:31:34 PM (4 years ago)
Author:
dbates@webkit.org
Message:

Remove unused WebPage::focusTextInputContext()
https://bugs.webkit.org/show_bug.cgi?id=211135

Reviewed by Anders Carlsson.

I accidentally forgot to remove the WebPage message and WebPage implementation that
backed -_focusTextInputContext when I removed it in r260225. Now the implementation
is unused. Let's remove it.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::focusTextInputContext): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
Location:
trunk/Source/WebKit
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebKit/ChangeLog

    r260844 r260846  
     12020-04-28  Daniel Bates  <dabates@apple.com>
     2
     3        Remove unused WebPage::focusTextInputContext()
     4        https://bugs.webkit.org/show_bug.cgi?id=211135
     5
     6        Reviewed by Anders Carlsson.
     7
     8        I accidentally forgot to remove the WebPage message and WebPage implementation that
     9        backed -_focusTextInputContext when I removed it in r260225. Now the implementation
     10        is unused. Let's remove it.
     11
     12        * WebProcess/WebPage/WebPage.cpp:
     13        (WebKit::WebPage::focusTextInputContext): Deleted.
     14        * WebProcess/WebPage/WebPage.h:
     15        * WebProcess/WebPage/WebPage.messages.in:
     16
    1172020-04-28  Christopher Reid  <chris.reid@sony.com>
    218
  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.cpp

    r260820 r260846  
    69336933}
    69346934
    6935 void WebPage::focusTextInputContext(const WebCore::ElementContext& textInputContext, CompletionHandler<void(bool)>&& completionHandler)
    6936 {
    6937     auto element = elementForContext(textInputContext);
    6938 
    6939     if (element)
    6940         element->focus();
    6941 
    6942     completionHandler(element);
    6943 }
    6944 
    69456935void WebPage::setCanShowPlaceholder(const WebCore::ElementContext& elementContext, bool canShowPlaceholder)
    69466936{
  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.h

    r260826 r260846  
    646646
    647647    void textInputContextsInRect(WebCore::FloatRect, CompletionHandler<void(const Vector<WebCore::ElementContext>&)>&&);
    648     void focusTextInputContext(const WebCore::ElementContext&, CompletionHandler<void(bool)>&&);
    649648    void setCanShowPlaceholder(const WebCore::ElementContext&, bool);
    650649
  • trunk/Source/WebKit/WebProcess/WebPage/WebPage.messages.in

    r260820 r260846  
    579579
    580580    TextInputContextsInRect(WebCore::FloatRect rect) -> (Vector<struct WebCore::ElementContext> contexts) Async
    581     FocusTextInputContext(struct WebCore::ElementContext context) -> (bool success) Async
    582581    SetCanShowPlaceholder(struct WebCore::ElementContext context, bool canShowPlaceholder)
    583582
Note: See TracChangeset for help on using the changeset viewer.