Changeset 260861 in webkit

Timestamp:

Apr 28, 2020 8:03:09 PM (4 years ago)

Author:

ddkilzer@apple.com

Message:

IPC::Decoder::isValid() should just be a nullptr check
<​https://webkit.org/b/211152>
<rdar://problem/62552699>

Reviewed by Darin Adler.

• Platform/IPC/Decoder.h:

(IPC::Decoder::isValid const): Change to nullptr check. I
reviewed the code in Decoder.{cpp,h}, and I didn't see
m_bufferPos being set without a bounds check. Also added
WARN_UNUSED_RETURN to make sure the result is always checked.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Platform/IPC/Decoder.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-04-28  David Kilzer  <ddkilzer@apple.com>
+
+        IPC::Decoder::isValid() should just be a nullptr check
+        <https://webkit.org/b/211152>
+        <rdar://problem/62552699>
+
+        Reviewed by Darin Adler.
+
+        * Platform/IPC/Decoder.h:
+        (IPC::Decoder::isValid const): Change to nullptr check.  I
+        reviewed the code in Decoder.{cpp,h}, and I didn't see
+        m_bufferPos being set without a bounds check.  Also added
+        WARN_UNUSED_RETURN to make sure the result is always checked.
+
 2020-04-28  Daniel Bates  <dabates@apple.com>
 

trunk/Source/WebKit/Platform/IPC/Decoder.h

@@ -72 +72 @@
     size_t length() const { return m_bufferEnd - m_buffer; }
 
-    bool isValid() const
-    {
-        // (m_bufferPos == m_bufferEnd) is a valid state for decoding if the last parameter
-        // is a variable length byte array and its size == 0.
-        return m_bufferPos >= m_buffer && m_bufferPos <= m_bufferEnd;
-    }
+    WARN_UNUSED_RETURN bool isValid() const { return m_bufferPos != nullptr; }
     void markInvalid() { m_bufferPos = nullptr; }