Changeset 260878 in webkit


Ignore:
Timestamp:
Apr 28, 2020 11:23:10 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, reverting r260876 and r260877.
https://bugs.webkit.org/show_bug.cgi?id=211165

Broke build (Requested by yusukesuzuki on #webkit).

Reverted changesets:

"Unreviewed, build fix on watchOS"
https://bugs.webkit.org/show_bug.cgi?id=210978
https://trac.webkit.org/changeset/260876

"Unreviewed, speculative build fix on watchOS part 2"
https://bugs.webkit.org/show_bug.cgi?id=210978
https://trac.webkit.org/changeset/260877

Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r260877 r260878  
     12020-04-28  Commit Queue  <commit-queue@webkit.org>
     2
     3        Unreviewed, reverting r260876 and r260877.
     4        https://bugs.webkit.org/show_bug.cgi?id=211165
     5
     6        Broke build (Requested by yusukesuzuki on #webkit).
     7
     8        Reverted changesets:
     9
     10        "Unreviewed, build fix on watchOS"
     11        https://bugs.webkit.org/show_bug.cgi?id=210978
     12        https://trac.webkit.org/changeset/260876
     13
     14        "Unreviewed, speculative build fix on watchOS part 2"
     15        https://bugs.webkit.org/show_bug.cgi?id=210978
     16        https://trac.webkit.org/changeset/260877
     17
    1182020-04-28  Yusuke Suzuki  <ysuzuki@apple.com>
    219
  • trunk/Source/JavaScriptCore/runtime/JSBigInt.cpp

    r260877 r260878  
    229229    if (msdTopBit < mantissaTopBit) {
    230230        remainingMantissaBits = mantissaTopBit - msdTopBit;
    231         digit = static_cast<Digit>(mantissa >> remainingMantissaBits);
     231        digit = mantissa >> remainingMantissaBits;
    232232        mantissa = mantissa << (64 - remainingMantissaBits);
    233233    } else {
    234234        ASSERT(msdTopBit >= mantissaTopBit);
    235         digit = static_cast<Digit>(mantissa << (msdTopBit - mantissaTopBit));
     235        digit = mantissa << (msdTopBit - mantissaTopBit);
    236236        mantissa = 0;
    237237    }
     
    319319};
    320320
    321 #if USE(BIGINT32)
    322321class Int32BigIntImpl {
    323322public:
     
    333332        ASSERT(length());
    334333        ASSERT_UNUSED(i, i == 0);
    335         static_assert(sizeof(Digit) == sizeof(uint64_t), "INT32_MAX can be represented with length() == 1 only when Digit is 64bit");
    336334        if (sign())
    337335            return -static_cast<int64_t>(m_value);
     
    345343    int32_t m_value;
    346344};
    347 #endif
    348345
    349346ALWAYS_INLINE JSBigInt::ImplResult::ImplResult(HeapBigIntImpl& heapImpl)
     
    13621359    return compareImpl(HeapBigIntImpl { x }, HeapBigIntImpl { y });
    13631360}
    1364 #if USE(BIGINT32)
    13651361JSBigInt::ComparisonResult JSBigInt::compare(int32_t x, JSBigInt* y)
    13661362{
     
    13711367    return compareImpl(HeapBigIntImpl { x }, Int32BigIntImpl { y });
    13721368}
    1373 #endif
    13741369
    13751370template <typename BigIntImpl1, typename BigIntImpl2>
  • trunk/Source/JavaScriptCore/runtime/JSBigInt.h

    r260876 r260878  
    139139    JS_EXPORT_PRIVATE bool equalsToInt32(int32_t);
    140140    static ComparisonResult compare(JSBigInt* x, JSBigInt* y);
    141 #if USE(BIGINT32)
    142141    static ComparisonResult compare(int32_t x, JSBigInt* y);
    143142    static ComparisonResult compare(JSBigInt* x, int32_t y);
     
    150149        return JSBigInt::ComparisonResult::GreaterThan;
    151150    }
    152 #endif
    153151
    154152    bool getPrimitiveNumber(JSGlobalObject*, double& number, JSValue& result) const;
Note: See TracChangeset for help on using the changeset viewer.