Changeset 260986 in webkit

Timestamp:

May 1, 2020 1:08:12 AM (4 years ago)

Author:

Adrian Perez de Castro

Message:

[GTK4] Disable arrow on context menu popover
​https://bugs.webkit.org/show_bug.cgi?id=211241

Reviewed by Carlos Garcia Campos.

Source/WebCore:

No new tests needed.

• platform/gtk/GtkVersioning.h:

(gdk_display_get_monitor_at_window): Add no-op stub for GTK3.

Source/WebKit:

• UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Disable the menu popover arrow.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/gtk/GtkVersioning.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-01  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [GTK4] Disable arrow on context menu popover
+        https://bugs.webkit.org/show_bug.cgi?id=211241
+
+        Reviewed by Carlos Garcia Campos.
+
+        No new tests needed.
+
+        * platform/gtk/GtkVersioning.h:
+        (gdk_display_get_monitor_at_window): Add no-op stub for GTK3.
+
 2020-04-30  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/platform/gtk/GtkVersioning.h

@@ -168 +168 @@
     gtk_widget_set_parent(GTK_WIDGET(popover), parent);
 }
+
+#else
+
+static inline void gtk_popover_set_has_arrow(GtkPopover*, gboolean)
+{
+}
+
 #endif // USE(GTK4)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-05-01  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [GTK4] Disable arrow on context menu popover
+        https://bugs.webkit.org/show_bug.cgi?id=211241
+
+        Reviewed by Carlos Garcia Campos.
+
+        * UIProcess/gtk/WebContextMenuProxyGtk.cpp:
+        (WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk): Disable the menu popover arrow.
+
 2020-04-30  Ross Kirsling  <ross.kirsling@sony.com>
 

trunk/Source/WebKit/UIProcess/gtk/WebContextMenuProxyGtk.cpp

@@ -192 +192 @@
     , m_menu(GTK_POPOVER(gtk_popover_menu_new()))
 {
+    gtk_popover_set_has_arrow(m_menu, FALSE);
     gtk_popover_set_position(m_menu, GTK_POS_BOTTOM);
     gtk_popover_set_relative_to(m_menu, m_webView);