Changeset 261271 in webkit
- Timestamp:
- May 7, 2020 12:00:17 AM (4 years ago)
- Location:
- trunk
- Files:
-
- 8 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/JSTests/ChangeLog
r261260 r261271 1 2020-05-07 Mark Lam <mark.lam@apple.com> 2 3 Fix broken exceptionFuzz tests. 4 https://bugs.webkit.org/show_bug.cgi?id=211550 5 6 Reviewed by Yusuke Suzuki. 7 8 The tests should not be relying on setting a JSC Option at runtime because the 9 options are already frozen by then. Instead, we set the needed 10 --useExceptionFuzz=true option from the command line. 11 12 * exceptionFuzz/3d-cube.js: 13 * exceptionFuzz/date-format-xparb.js: 14 * exceptionFuzz/earley-boyer.js: 15 1 16 2020-05-06 Keith Miller <keith_miller@apple.com> 2 17 -
trunk/JSTests/exceptionFuzz/3d-cube.js
r225129 r261271 1 var enableExceptionFuzz = $vm.enableExceptionFuzz;2 3 1 try { 4 2 … … 6 4 // http://www.speich.net/computer/moztesting/3d.htm 7 5 // Created by Simon Speich 8 9 enableExceptionFuzz();10 11 6 12 7 var Q = new Array(); -
trunk/JSTests/exceptionFuzz/date-format-xparb.js
r225129 r261271 1 var enableExceptionFuzz = $vm.enableExceptionFuzz;2 3 1 try { 4 2 … … 15 13 * details. 16 14 */ 17 18 enableExceptionFuzz();19 20 15 21 16 Date.parseFunctions = {count:0}; -
trunk/JSTests/exceptionFuzz/earley-boyer.js
r225129 r261271 1 var enableExceptionFuzz = $vm.enableExceptionFuzz;2 3 1 try { 4 2 // This file is automatically generated by scheme2js, except for the … … 41 39 } 42 40 */ 43 44 enableExceptionFuzz();45 46 41 47 42 function sc_print_debug() { -
trunk/Source/JavaScriptCore/ChangeLog
r261260 r261271 1 2020-05-07 Mark Lam <mark.lam@apple.com> 2 3 Fix broken exceptionFuzz tests. 4 https://bugs.webkit.org/show_bug.cgi?id=211550 5 6 Reviewed by Yusuke Suzuki. 7 8 Remove the bad and now unused utility function to set Options::useExceptionFuzz(). 9 10 * tools/JSDollarVM.cpp: 11 (JSC::JSDollarVM::finishCreation): 12 (JSC::functionEnableExceptionFuzz): Deleted. 13 1 14 2020-05-06 Keith Miller <keith_miller@apple.com> 2 15 -
trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp
r260990 r261271 2679 2679 } 2680 2680 2681 static EncodedJSValue JSC_HOST_CALL functionEnableExceptionFuzz(JSGlobalObject*, CallFrame*)2682 {2683 DollarVMAssertScope assertScope;2684 Options::useExceptionFuzz() = true;2685 return JSValue::encode(jsUndefined());2686 }2687 2688 2681 class DoNothingDebugger final : public Debugger { 2689 2682 WTF_MAKE_NONCOPYABLE(DoNothingDebugger); … … 3096 3089 addFunction(vm, "basicBlockExecutionCount", functionBasicBlockExecutionCount, 2); 3097 3090 3098 addFunction(vm, "enableExceptionFuzz", functionEnableExceptionFuzz, 0);3099 3100 3091 addFunction(vm, "enableDebuggerModeWhenIdle", functionEnableDebuggerModeWhenIdle, 0); 3101 3092 addFunction(vm, "disableDebuggerModeWhenIdle", functionDisableDebuggerModeWhenIdle, 0); -
trunk/Tools/ChangeLog
r261250 r261271 1 2020-05-07 Mark Lam <mark.lam@apple.com> 2 3 Fix broken exceptionFuzz tests. 4 https://bugs.webkit.org/show_bug.cgi?id=211550 5 6 Reviewed by Yusuke Suzuki. 7 8 Pass the --useExceptionFuzz=true option from the command line for runExceptionFuzz. 9 10 * Scripts/run-jsc-stress-tests: 11 1 12 2020-05-06 Kate Cheney <katherine_cheney@apple.com> 2 13 -
trunk/Tools/Scripts/run-jsc-stress-tests
r261215 r261271 966 966 967 967 def runExceptionFuzz 968 subCommand = escapeAll([pathToVM.to_s, "--useDollarVM=true", $benchmark.to_s])968 subCommand = escapeAll([pathToVM.to_s, "--useDollarVM=true", "--useExceptionFuzz=true", $benchmark.to_s]) 969 969 addRunCommand("exception-fuzz", ["perl", (pathToHelpers + "js-exception-fuzz").to_s, subCommand], silentOutputHandler, simpleErrorHandler) 970 970 end
Note: See TracChangeset
for help on using the changeset viewer.