Changeset 261271 in webkit


Ignore:
Timestamp:
May 7, 2020 12:00:17 AM (4 years ago)
Author:
mark.lam@apple.com
Message:

Fix broken exceptionFuzz tests.
https://bugs.webkit.org/show_bug.cgi?id=211550

Reviewed by Yusuke Suzuki.

JSTests:

The tests should not be relying on setting a JSC Option at runtime because the
options are already frozen by then. Instead, we set the needed
--useExceptionFuzz=true option from the command line.

  • exceptionFuzz/3d-cube.js:
  • exceptionFuzz/date-format-xparb.js:
  • exceptionFuzz/earley-boyer.js:

Source/JavaScriptCore:

Remove the bad and now unused utility function to set Options::useExceptionFuzz().

  • tools/JSDollarVM.cpp:

(JSC::JSDollarVM::finishCreation):
(JSC::functionEnableExceptionFuzz): Deleted.

Tools:

Pass the --useExceptionFuzz=true option from the command line for runExceptionFuzz.

  • Scripts/run-jsc-stress-tests:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/JSTests/ChangeLog

    r261260 r261271  
     12020-05-07  Mark Lam  <mark.lam@apple.com>
     2
     3        Fix broken exceptionFuzz tests.
     4        https://bugs.webkit.org/show_bug.cgi?id=211550
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        The tests should not be relying on setting a JSC Option at runtime because the
     9        options are already frozen by then.  Instead, we set the needed
     10        --useExceptionFuzz=true option from the command line.
     11
     12        * exceptionFuzz/3d-cube.js:
     13        * exceptionFuzz/date-format-xparb.js:
     14        * exceptionFuzz/earley-boyer.js:
     15
    1162020-05-06  Keith Miller  <keith_miller@apple.com>
    217
  • trunk/JSTests/exceptionFuzz/3d-cube.js

    r225129 r261271  
    1 var enableExceptionFuzz = $vm.enableExceptionFuzz;
    2 
    31try {
    42
     
    64// http://www.speich.net/computer/moztesting/3d.htm
    75// Created by Simon Speich
    8 
    9 enableExceptionFuzz();
    10 
    116
    127var Q = new Array();
  • trunk/JSTests/exceptionFuzz/date-format-xparb.js

    r225129 r261271  
    1 var enableExceptionFuzz = $vm.enableExceptionFuzz;
    2 
    31try {
    42
     
    1513 * details.
    1614 */
    17 
    18 enableExceptionFuzz();
    19 
    2015
    2116Date.parseFunctions = {count:0};
  • trunk/JSTests/exceptionFuzz/earley-boyer.js

    r225129 r261271  
    1 var enableExceptionFuzz = $vm.enableExceptionFuzz;
    2 
    31try {
    42// This file is automatically generated by scheme2js, except for the
     
    4139}
    4240*/
    43 
    44 enableExceptionFuzz();
    45 
    4641
    4742function sc_print_debug() {
  • trunk/Source/JavaScriptCore/ChangeLog

    r261260 r261271  
     12020-05-07  Mark Lam  <mark.lam@apple.com>
     2
     3        Fix broken exceptionFuzz tests.
     4        https://bugs.webkit.org/show_bug.cgi?id=211550
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        Remove the bad and now unused utility function to set Options::useExceptionFuzz().
     9
     10        * tools/JSDollarVM.cpp:
     11        (JSC::JSDollarVM::finishCreation):
     12        (JSC::functionEnableExceptionFuzz): Deleted.
     13
    1142020-05-06  Keith Miller  <keith_miller@apple.com>
    215
  • trunk/Source/JavaScriptCore/tools/JSDollarVM.cpp

    r260990 r261271  
    26792679}
    26802680
    2681 static EncodedJSValue JSC_HOST_CALL functionEnableExceptionFuzz(JSGlobalObject*, CallFrame*)
    2682 {
    2683     DollarVMAssertScope assertScope;
    2684     Options::useExceptionFuzz() = true;
    2685     return JSValue::encode(jsUndefined());
    2686 }
    2687 
    26882681class DoNothingDebugger final : public Debugger {
    26892682    WTF_MAKE_NONCOPYABLE(DoNothingDebugger);
     
    30963089    addFunction(vm, "basicBlockExecutionCount", functionBasicBlockExecutionCount, 2);
    30973090
    3098     addFunction(vm, "enableExceptionFuzz", functionEnableExceptionFuzz, 0);
    3099 
    31003091    addFunction(vm, "enableDebuggerModeWhenIdle", functionEnableDebuggerModeWhenIdle, 0);
    31013092    addFunction(vm, "disableDebuggerModeWhenIdle", functionDisableDebuggerModeWhenIdle, 0);
  • trunk/Tools/ChangeLog

    r261250 r261271  
     12020-05-07  Mark Lam  <mark.lam@apple.com>
     2
     3        Fix broken exceptionFuzz tests.
     4        https://bugs.webkit.org/show_bug.cgi?id=211550
     5
     6        Reviewed by Yusuke Suzuki.
     7
     8        Pass the --useExceptionFuzz=true option from the command line for runExceptionFuzz.
     9
     10        * Scripts/run-jsc-stress-tests:
     11
    1122020-05-06  Kate Cheney  <katherine_cheney@apple.com>
    213
  • trunk/Tools/Scripts/run-jsc-stress-tests

    r261215 r261271  
    966966
    967967def runExceptionFuzz
    968     subCommand = escapeAll([pathToVM.to_s, "--useDollarVM=true", $benchmark.to_s])
     968    subCommand = escapeAll([pathToVM.to_s, "--useDollarVM=true", "--useExceptionFuzz=true", $benchmark.to_s])
    969969    addRunCommand("exception-fuzz", ["perl", (pathToHelpers + "js-exception-fuzz").to_s, subCommand], silentOutputHandler, simpleErrorHandler)
    970970end
Note: See TracChangeset for help on using the changeset viewer.