Changeset 261285 in webkit


Ignore:
Timestamp:
May 7, 2020 7:29:38 AM (4 years ago)
Author:
Andres Gonzalez
Message:

Fix for crash in AXIsolatedObject::identifierAttribute.
https://bugs.webkit.org/show_bug.cgi?id=211565

Reviewed by Chris Fleizach.

Covered by existing tests.

When adding the identifierAttribute property to the AXIsolatedObject's
properties map, must make an isolatedCopy of it in order to retrieve it
on the secondary thread.

  • accessibility/isolatedtree/AXIsolatedObject.cpp:

(WebCore::AXIsolatedObject::initializeAttributeData):

Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r261279 r261285  
     12020-05-07  Andres Gonzalez  <andresg_22@apple.com>
     2
     3        Fix for crash in AXIsolatedObject::identifierAttribute.
     4        https://bugs.webkit.org/show_bug.cgi?id=211565
     5
     6        Reviewed by Chris Fleizach.
     7
     8        Covered by existing tests.
     9
     10        When adding the identifierAttribute property to the AXIsolatedObject's
     11        properties map, must make an isolatedCopy of it in order to retrieve it
     12        on the secondary thread.
     13
     14        * accessibility/isolatedtree/AXIsolatedObject.cpp:
     15        (WebCore::AXIsolatedObject::initializeAttributeData):
     16
    1172020-05-07  Antti Koivisto  <antti@apple.com>
    218
  • trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp

    r261248 r261285  
    162162    setProperty(AXPropertyName::CanvasHasFallbackContent, object.canvasHasFallbackContent());
    163163    setProperty(AXPropertyName::SupportsRangeValue, object.supportsRangeValue());
    164     setProperty(AXPropertyName::IdentifierAttribute, object.identifierAttribute());
     164    setProperty(AXPropertyName::IdentifierAttribute, object.identifierAttribute().isolatedCopy());
    165165    setProperty(AXPropertyName::LinkRelValue, object.linkRelValue());
    166166    setProperty(AXPropertyName::CurrentState, static_cast<int>(object.currentState()));
Note: See TracChangeset for help on using the changeset viewer.