Changeset 261444 in webkit

Timestamp:

May 9, 2020 4:35:11 PM (4 years ago)

Author:

don.olmstead@sony.com

Message:

[CMake] Use WEBKIT_EXECUTABLE in MallocBench
​https://bugs.webkit.org/show_bug.cgi?id=211665

Reviewed by Yusuke Suzuki.

.:

Add the PerformanceTest subdirectory for all ports when in DEVELOPER_MODE.

• CMakeLists.txt:

PerformanceTests:

Cleanup MallocBench definitions using WEBKIT_EXECUTABLE. Notify developers
that MallocBench is unavailable only if bmalloc is being used but the platform
does not have the functionality required.

• CMakeLists.txt:
• MallocBench/MallocBench/CMakeLists.txt:

Source/bmalloc:

Only build mbmalloc if its possible to run MallocBench.

• CMakeLists.txt:

Location:

trunk

Files:

• CMakeLists.txt (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• PerformanceTests/CMakeLists.txt (modified) (1 diff)
• PerformanceTests/ChangeLog (modified) (1 diff)
• PerformanceTests/MallocBench/MallocBench/CMakeLists.txt (modified) (3 diffs)
• Source/bmalloc/CMakeLists.txt (modified) (1 diff)
• Source/bmalloc/ChangeLog (modified) (1 diff)

trunk/CMakeLists.txt

@@ -192 +192 @@
 endif ()
 
-if ("${PORT}" STREQUAL "GTK" OR "${PORT}" STREQUAL "WPE")
-    if (DEVELOPER_MODE)
-        add_subdirectory(PerformanceTests)
-    endif ()
-else ()
+if (DEVELOPER_MODE)
     add_subdirectory(PerformanceTests)
 endif ()

trunk/ChangeLog

@@ +1 @@
+2020-05-09  Don Olmstead  <don.olmstead@sony.com>
+
+        [CMake] Use WEBKIT_EXECUTABLE in MallocBench
+        https://bugs.webkit.org/show_bug.cgi?id=211665
+
+        Reviewed by Yusuke Suzuki.
+
+        Add the PerformanceTest subdirectory for all ports when in DEVELOPER_MODE.
+
+        * CMakeLists.txt:
+
 2020-05-07  Philippe Normand  <pnormand@igalia.com>
 

trunk/PerformanceTests/CMakeLists.txt

@@ -1 +1 @@
 # MallocBench requires malloc_trim for non-Apple platforms
-if (NOT USE_SYSTEM_MALLOC AND (APPLE OR HAVE_MALLOC_TRIM))
-    add_subdirectory(MallocBench)
-else ()
-    message(WARNING "MallocBench is not available on this platform")
+if (NOT USE_SYSTEM_MALLOC)
+    if (APPLE OR HAVE_MALLOC_TRIM)
+        add_subdirectory(MallocBench)
+    else ()
+        message(WARNING "MallocBench is not available on this platform")
+    endif ()
 endif ()
 

trunk/PerformanceTests/ChangeLog

@@ +1 @@
+2020-05-09  Don Olmstead  <don.olmstead@sony.com>
+
+        [CMake] Use WEBKIT_EXECUTABLE in MallocBench
+        https://bugs.webkit.org/show_bug.cgi?id=211665
+
+        Reviewed by Yusuke Suzuki.
+
+        Cleanup MallocBench definitions using WEBKIT_EXECUTABLE. Notify developers
+        that MallocBench is unavailable only if bmalloc is being used but the platform
+        does not have the functionality required.
+
+        * CMakeLists.txt:
+        * MallocBench/MallocBench/CMakeLists.txt:
+
 2020-05-08  Darin Adler  <darin@apple.com>
 

trunk/PerformanceTests/MallocBench/MallocBench/CMakeLists.txt

@@ -1 @@
-add_library(sysmalloc SHARED mbmalloc.cpp)
-set_target_properties(sysmalloc PROPERTIES OUTPUT_NAME "mbmalloc")
-set_target_properties(sysmalloc PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/lib/system/)
-
-set(MALLOC_BENCH_SOURCES
+set(MallocBench_SOURCES
     Benchmark.cpp
     CPUCount.cpp
@@ -29 +25 @@
 )
 
-set(MALLOC_BENCH_INCLUDE_DIRECTORIES
-    "${BMALLOC_DIR}"
-    "${CMAKE_BINARY_DIR}"
-    "${DERIVED_SOURCES_DIR}"
-    "${THIRDPARTY_DIR}"
+set(MallocBench_PRIVATE_INCLUDE_DIRECTORIES
+    ${CMAKE_BINARY_DIR}
+    ${bmalloc_FRAMEWORK_HEADERS_DIR}
 )
 
-set(MALLOC_BENCH_LIBRARIES
+set(MallocBench_PRIVATE_LIBRARIES
     ${CMAKE_DL_LIBS}
+    Threads::Threads
+    mbmalloc
 )
 
-WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
+set(MallocBench_DEPENDENCIES sysmalloc)
 
-WEBKIT_WRAP_SOURCELIST(${MALLOC_BENCH_SOURCES})
-
-
-include_directories(${MALLOC_BENCH_INCLUDE_DIRECTORIES})
-
-SET(CMAKE_SKIP_BUILD_RPATH  TRUE)
-if (DEVELOPER_MODE)
-    add_executable(MallocBench ${MALLOC_BENCH_SOURCES})
-    target_link_libraries(MallocBench ${MALLOC_BENCH_LIBRARIES} Threads::Threads mbmalloc)
-    add_dependencies(MallocBench sysmalloc mbmalloc)
-endif ()
-
-set(MALLOC_BENCH_OPS
+set(MallocBench_OPS
     facebook.ops
     flickr.ops
@@ -65 +49 @@
 )
 
+WEBKIT_EXECUTABLE_DECLARE(MallocBench)
+WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS()
+
+set(CMAKE_SKIP_BUILD_RPATH ON)
+add_library(sysmalloc SHARED mbmalloc.cpp)
+set_target_properties(sysmalloc PROPERTIES OUTPUT_NAME "mbmalloc")
+set_target_properties(sysmalloc PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR}/lib/system/)
+
 file(COPY
-    ${MALLOC_BENCH_OPS}
+    ${MallocBench_OPS}
     DESTINATION
     ${PROJECT_BINARY_DIR}
 )
+
+WEBKIT_WRAP_SOURCELIST(${MallocBench_SOURCES})
+WEBKIT_EXECUTABLE(MallocBench)

trunk/Source/bmalloc/CMakeLists.txt

@@ -158 +158 @@
 WEBKIT_FRAMEWORK_TARGET(bmalloc)
 
-if (DEVELOPER_MODE)
+# Only build mbmalloc on platforms that MallocBench supports
+if (DEVELOPER_MODE AND (APPLE OR HAVE_MALLOC_TRIM))
     add_library(mbmalloc SHARED bmalloc/mbmalloc.cpp)
     target_include_directories(mbmalloc PRIVATE ${bmalloc_PRIVATE_INCLUDE_DIRECTORIES})

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2020-05-09  Don Olmstead  <don.olmstead@sony.com>
+
+        [CMake] Use WEBKIT_EXECUTABLE in MallocBench
+        https://bugs.webkit.org/show_bug.cgi?id=211665
+
+        Reviewed by Yusuke Suzuki.
+
+        Only build mbmalloc if its possible to run MallocBench.
+
+        * CMakeLists.txt:
+
 2020-05-08  Basuke Suzuki  <basuke.suzuki@sony.com>