Changeset 261458 in webkit

Timestamp:

May 10, 2020 2:21:14 PM (4 years ago)

Author:

Darin Adler

Message:

Use makeReversedRange and get rid of one-off ReverseView
​https://bugs.webkit.org/show_bug.cgi?id=211675

Reviewed by Sam Weinig.

• editing/markup.cpp:

(WebCore::ReverseView): Deleted.
(WebCore::StyledMarkupAccumulator::takeResults): Use makeReversedRange.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• editing/markup.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-10  Darin Adler  <darin@apple.com>
+
+        Use makeReversedRange and get rid of one-off ReverseView
+        https://bugs.webkit.org/show_bug.cgi?id=211675
+
+        Reviewed by Sam Weinig.
+
+        * editing/markup.cpp:
+        (WebCore::ReverseView): Deleted.
+        (WebCore::StyledMarkupAccumulator::takeResults): Use makeReversedRange.
+
 2020-05-10  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/editing/markup.cpp

@@ -395 +395 @@
 }
 
-// Stopgap until C++20 adds std::ranges::reverse_view.
-template<typename Collection> struct ReverseView {
-    Collection& collection;
-    decltype(collection.rbegin()) begin() const { return collection.rbegin(); }
-    decltype(collection.rend()) end() const { return collection.rend(); }
-    decltype(collection.size()) size() const { return collection.size(); }
-    ReverseView(Collection& collection)
-        : collection(collection)
-    {
-    }
-};
-
 String StyledMarkupAccumulator::takeResults()
 {
@@ -414 +402 @@
     StringBuilder result;
     result.reserveCapacity(length.unsafeGet());
-    for (auto& string : ReverseView { m_reversedPrecedingMarkup })
+    for (auto& string : makeReversedRange(m_reversedPrecedingMarkup))
         result.append(string);
     result.append(takeMarkup());