Changeset 261534 in webkit

Timestamp:

May 11, 2020 5:38:36 PM (4 years ago)

Author:

sbarati@apple.com

Message:

Remove OTHER_CFLAGS="" in libwebrtc pbxproj
​https://bugs.webkit.org/show_bug.cgi?id=211742

Reviewed by Darin Adler.

I believe this was done by accident in a larger patch. If we did indeed
want to define OTHER_CFLAGS to be empty, the right place for that is inside
the xcconfig files, not the pbxproj files.

• libwebrtc.xcodeproj/project.pbxproj:

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• ChangeLog (modified) (1 diff)
• libwebrtc.xcodeproj/project.pbxproj (modified) (13 diffs)

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2020-05-11  Saam Barati  <sbarati@apple.com>
+
+        Remove OTHER_CFLAGS="" in libwebrtc pbxproj
+        https://bugs.webkit.org/show_bug.cgi?id=211742
+
+        Reviewed by Darin Adler.
+
+        I believe this was done by accident in a larger patch. If we did indeed
+        want to define OTHER_CFLAGS to be empty, the right place for that is inside
+        the xcconfig files, not the pbxproj files.
+
+        * libwebrtc.xcodeproj/project.pbxproj:
+
 2020-04-30  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj

@@ -18553 +18553 @@
                                 CLANG_X86_VECTOR_INSTRUCTIONS = default;
                                 HEADER_SEARCH_PATHS = "$(inherited)";
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                                 USE_HEADERMAP = NO;
@@ -18566 +18565 @@
                                 CLANG_X86_VECTOR_INSTRUCTIONS = default;
                                 HEADER_SEARCH_PATHS = "$(inherited)";
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                                 USE_HEADERMAP = NO;
@@ -18579 +18577 @@
                                 CLANG_X86_VECTOR_INSTRUCTIONS = default;
                                 HEADER_SEARCH_PATHS = "$(inherited)";
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                                 USE_HEADERMAP = NO;
@@ -18696 +18693 @@
                                         Source/third_party/rnnoise,
                                 );
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                         };
@@ -18718 +18714 @@
                                         Source/third_party/rnnoise,
                                 );
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                         };
@@ -18772 +18767 @@
                         baseConfigurationReference = 5C4B4A8F1E42C431002651C8 /* opus.xcconfig */;
                         buildSettings = {
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                         };
@@ -18781 +18775 @@
                         baseConfigurationReference = 5C4B4A8F1E42C431002651C8 /* opus.xcconfig */;
                         buildSettings = {
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                         };
@@ -18790 +18783 @@
                         baseConfigurationReference = 5C4B4A8F1E42C431002651C8 /* opus.xcconfig */;
                         buildSettings = {
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                         };
@@ -18823 +18815 @@
                         baseConfigurationReference = 5C4B43B01E42877A002651C8 /* boringssl.xcconfig */;
                         buildSettings = {
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                         };
@@ -18832 +18823 @@
                         baseConfigurationReference = 5C4B43B01E42877A002651C8 /* boringssl.xcconfig */;
                         buildSettings = {
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                         };
@@ -18841 +18831 @@
                         baseConfigurationReference = 5C4B43B01E42877A002651C8 /* boringssl.xcconfig */;
                         buildSettings = {
-                                OTHER_CFLAGS = "";
                                 PRODUCT_NAME = "$(TARGET_NAME)";
                         };
@@ -18862 +18851 @@
                                 );
                                 HEADER_SEARCH_PATHS = "$(inherited)";
-                                OTHER_CFLAGS = "";
                         };
                         name = Production;
@@ -18902 +18890 @@
                                 );
                                 HEADER_SEARCH_PATHS = "$(inherited)";
-                                OTHER_CFLAGS = "";
                         };
                         name = Release;