Changeset 26156 in webkit

Timestamp:

Oct 9, 2007 2:02:38 AM (17 years ago)

Author:

rwlbuis

Message:

Reviewed by Maciej.

​http://bugs.webkit.org/show_bug.cgi?id=15088
HTMLOptionElement.selected returns false when parent HTMLSelectElement is "display: none" until parent's .selectedIndex is accessed

Make sure the list items are up to date when there is no renderer.

Location:

branches/feature-branch

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/HTMLOptionElement_selected-expected.txt (added)
• LayoutTests/fast/forms/HTMLOptionElement_selected.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/html/HTMLSelectElement.cpp (modified) (1 diff)

branches/feature-branch/LayoutTests/ChangeLog

@@ +1 @@
+2007-10-09  Rob Buis  <buis@kde.org>
+
+        Reviewed by Maciej.
+
+        Testcase for:
+        http://bugs.webkit.org/show_bug.cgi?id=15088
+        HTMLOptionElement.selected returns false when parent HTMLSelectElement is "display: none" until parent's .selectedIndex is accessed
+
+        * fast/forms/HTMLOptionElement_selected-expected.txt: Added.
+        * fast/forms/HTMLOptionElement_selected.html: Added.
+
 === start merge of trunk/25970-26102 08-10-2007 ===
 

branches/feature-branch/WebCore/ChangeLog

@@ +1 @@
+2007-10-09  Rob Buis  <buis@kde.org>
+
+        Reviewed by Maciej.
+
+        http://bugs.webkit.org/show_bug.cgi?id=15088
+        HTMLOptionElement.selected returns false when parent HTMLSelectElement is "display: none" until parent's .selectedIndex is accessed
+
+        Make sure the list items are up to date when there is no renderer.
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::recalcStyle):
+
 === start merge of trunk/25970-26102 08-10-2007 ===
 

branches/feature-branch/WebCore/html/HTMLSelectElement.cpp

@@ -107 +107 @@
         else
             static_cast<RenderListBox*>(renderer())->setOptionsChanged(true);
-    }
+    } else if (m_recalcListItems)
+        recalcListItems();
 
     HTMLFormControlElementWithState::recalcStyle(ch);