Changeset 261564 in webkit


Ignore:
Timestamp:
May 12, 2020 10:40:21 AM (4 years ago)
Author:
commit-queue@webkit.org
Message:

-Wsign-compare warnings in FTLLowerDFGToB3.cpp and DFGSpeculativeJIT.cpp
https://bugs.webkit.org/show_bug.cgi?id=211783

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-05-12
Reviewed by Darin Adler.

This fixes -Wsign-compare warnings introduced in r260331.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileValueBitNot):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot):

Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r261556 r261564  
     12020-05-12  Michael Catanzaro  <mcatanzaro@gnome.org>
     2
     3        -Wsign-compare warnings in FTLLowerDFGToB3.cpp and DFGSpeculativeJIT.cpp
     4        https://bugs.webkit.org/show_bug.cgi?id=211783
     5
     6        Reviewed by Darin Adler.
     7
     8        This fixes -Wsign-compare warnings introduced in r260331.
     9
     10        * dfg/DFGSpeculativeJIT.cpp:
     11        (JSC::DFG::SpeculativeJIT::compileValueBitNot):
     12        * ftl/FTLLowerDFGToB3.cpp:
     13        (JSC::FTL::DFG::LowerDFGToB3::compileValueBitNot):
     14
    1152020-05-12  Truitt Savell  <tsavell@apple.com>
    216
  • trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp

    r261464 r261564  
    35983598        // The following trick relies on details of the representation of BigInt32, and will have to be updated if we move bits around.
    35993599        static_assert(JSValue::BigInt32Tag == 0x12);
    3600         static_assert(JSValue::BigInt32Mask == 0xfffe000000000012);
     3600        static_assert(JSValue::BigInt32Mask == static_cast<int64_t>(0xfffe000000000012));
    36013601        constexpr uint64_t maskForBigInt32Bits = 0x0000ffffffff0000;
    36023602        static_assert(!(JSValue::BigInt32Mask & maskForBigInt32Bits));
  • trunk/Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

    r261464 r261564  
    33443344            // The following trick relies on details of the representation of BigInt32, and will have to be updated if we move bits around.
    33453345            static_assert(JSValue::BigInt32Tag == 0x12);
    3346             static_assert(JSValue::BigInt32Mask == 0xfffe000000000012);
     3346            static_assert(JSValue::BigInt32Mask == static_cast<int64_t>(0xfffe000000000012));
    33473347            uint64_t maskForBigInt32Bits = 0x0000ffffffff0000;
    33483348            LValue result = m_out.bitXor(operand, m_out.constInt64(maskForBigInt32Bits));
Note: See TracChangeset for help on using the changeset viewer.