Changeset 261579 in webkit


Ignore:
Timestamp:
May 12, 2020 2:18:30 PM (4 years ago)
Author:
achristensen@apple.com
Message:

[iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=211786

Reviewed by Darin Adler.

This should turn the test crash into a failure, which is a step in the right direction.
Still investigating...

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(TEST):

Location:
trunk/Tools
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Tools/ChangeLog

    r261568 r261579  
     12020-05-12  Alex Christensen  <achristensen@webkit.org>
     2
     3        [iOS Simulator] TestWebKitAPI._WKDownload.Resume is a flaky crash
     4        https://bugs.webkit.org/show_bug.cgi?id=211786
     5
     6        Reviewed by Darin Adler.
     7
     8        This should turn the test crash into a failure, which is a step in the right direction.
     9        Still investigating...
     10
     11        * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
     12        (TEST):
     13
    1142020-05-12  Ryan Haddad  <ryanhaddad@apple.com>
    215
  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm

    r260518 r261579  
    12821282    NSData *fileContents = [NSData dataWithContentsOfURL:expectedDownloadFile];
    12831283    EXPECT_EQ(fileContents.length, 10000u);
    1284     for (size_t i = 0; i < 5000; i++)
    1285         EXPECT_EQ(static_cast<const char*>(fileContents.bytes)[i], 'a');
    1286     for (size_t i = 5000; i < 10000; i++)
    1287         EXPECT_EQ(static_cast<const char*>(fileContents.bytes)[i], 'b');
     1284    EXPECT_TRUE(fileContents.bytes);
     1285    if (fileContents.bytes) {
     1286        for (size_t i = 0; i < 5000; i++)
     1287            EXPECT_EQ(static_cast<const char*>(fileContents.bytes)[i], 'a');
     1288        for (size_t i = 5000; i < 10000; i++)
     1289            EXPECT_EQ(static_cast<const char*>(fileContents.bytes)[i], 'b');
     1290    }
    12881291}
    12891292
Note: See TracChangeset for help on using the changeset viewer.