Changeset 261653 in webkit
- Timestamp:
- May 13, 2020 1:51:52 PM (4 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 2 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r261651 r261653 1 2020-05-13 Andres Gonzalez <andresg_22@apple.com> 2 3 Remove unnecessary assert in {WebAccessibilityObjectWrapper attachmentView]. 4 https://bugs.webkit.org/show_bug.cgi?id=211857 5 6 Reviewed by Chris Fleizach. 7 8 This assert is unnecessary since the backing object that is relevant is 9 the one on the main thread. This was causing crashes in LayoutTest in 10 isolated tree mode. 11 12 * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: 13 (-[WebAccessibilityObjectWrapper attachmentView]): 14 1 15 2020-05-13 Jer Noble <jer.noble@apple.com> 2 16 -
trunk/Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm
r261536 r261653 557 557 - (id)attachmentView 558 558 { 559 ASSERT(self.axBackingObject->isAttachment());560 561 559 return Accessibility::retrieveAutoreleasedValueFromMainThread<id>([protectedSelf = retainPtr(self)] () -> RetainPtr<id> { 562 auto* widget = protectedSelf.get().axBackingObject->widgetForAttachmentView();563 if (! widget)560 auto* backingObject = protectedSelf.get().axBackingObject; 561 if (!backingObject) 564 562 return nil; 565 return NSAccessibilityUnignoredDescendant(widget->platformWidget()); 563 564 auto* widget = backingObject->widgetForAttachmentView(); 565 return widget ? NSAccessibilityUnignoredDescendant(widget->platformWidget()) : nil; 566 566 }); 567 567 }
Note: See TracChangeset
for help on using the changeset viewer.