Changeset 261678 in webkit


Ignore:
Timestamp:
May 13, 2020 11:58:46 PM (4 years ago)
Author:
mmaxfield@apple.com
Message:

fast/text/multiple-codeunit-vertical-upright.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=211860
<rdar://problem/31893714>

Reviewed by Megan Gardner.

Font metrics were hard-coded into the test. This patch adds a new font,
Ahem-multi-code-unit.ttf, which has predictable metrics so we don't have
to bake in the metrics into the test. The test is no longer sensitive
to fallback fonts and their metrics.

  • fast/text/multiple-codeunit-vertical-upright-2-expected.html: Added.
  • fast/text/multiple-codeunit-vertical-upright-2.html: Added.
  • fast/text/multiple-codeunit-vertical-upright-expected.html:
  • fast/text/multiple-codeunit-vertical-upright.html:
  • fast/text/resources/Ahem-multi-code-unit.ttf: Added.
  • platform/ios/TestExpectations:
  • platform/mac-wk1/TestExpectations:
Location:
trunk/LayoutTests
Files:
3 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r261677 r261678  
     12020-05-13  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        fast/text/multiple-codeunit-vertical-upright.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=211860
     5        <rdar://problem/31893714>
     6
     7        Reviewed by Megan Gardner.
     8
     9        Font metrics were hard-coded into the test. This patch adds a new font,
     10        Ahem-multi-code-unit.ttf, which has predictable metrics so we don't have
     11        to bake in the metrics into the test. The test is no longer sensitive
     12        to fallback fonts and their metrics.
     13
     14        * fast/text/multiple-codeunit-vertical-upright-2-expected.html: Added.
     15        * fast/text/multiple-codeunit-vertical-upright-2.html: Added.
     16        * fast/text/multiple-codeunit-vertical-upright-expected.html:
     17        * fast/text/multiple-codeunit-vertical-upright.html:
     18        * fast/text/resources/Ahem-multi-code-unit.ttf: Added.
     19        * platform/ios/TestExpectations:
     20        * platform/mac-wk1/TestExpectations:
     21
    1222020-05-13  Lauro Moura  <lmoura@igalia.com>
    223

  • trunk/LayoutTests/fast/text/multiple-codeunit-vertical-upright-expected.html

    r188023 r261678  
    22<html>
    33<head>
     4<style>
     5@font-face {
     6    font-family: "WebFont";
     7    src: url("resources/Ahem-multi-code-unit.ttf") format("truetype");
     8}
     9</style>
    410</head>
    511<body style="-webkit-font-smoothing: none;">
    6 <div style="position: absolute; top: 100px;">This test makes sure that upright vertical text is rendered the same as horizontal text.</div>
    7 <div style="font: 96px Times; position: relative; left: 29px; top: -23px; display: inline-block;">&#x2000b;</div>
     12<div style="position: absolute; top: 120px;">This test makes sure that upright vertical text is rendered the same as horizontal text. The test passes if you see a horizontal line above.</div>
     13<div style="font: 100px 'WebFont'; position: relative; display: inline-block;">&#x2000b;</div>
    814</body>
    915</html>

  • trunk/LayoutTests/fast/text/multiple-codeunit-vertical-upright.html

    r188023 r261678  
    22<html>
    33<head>
     4<style>
     5@font-face {
     6    font-family: "WebFont";
     7    src: url("resources/Ahem-multi-code-unit.ttf") format("truetype");
     8}
     9</style>
    410</head>
    511<body style="-webkit-font-smoothing: none;">
    6 <div style="position: absolute; top: 100px;">This test makes sure that upright vertical text is rendered the same as horizontal text.</div>
    7 <div style="font: 96px Times; -webkit-writing-mode: vertical-rl; -webkit-text-orientation: upright;">&#x2000b;</div>
     12<div style="position: absolute; top: 120px;">This test makes sure that upright vertical text is rendered the same as horizontal text. The test passes if you see a horizontal line above.</div>
     13<div style="font: 100px 'WebFont'; -webkit-writing-mode: vertical-rl; -webkit-text-orientation: upright;">&#x2000b;</div>
    814</body>
    915</html>

  • trunk/LayoutTests/platform/ios/TestExpectations

    r261641 r261678  
    21642164fast/text/han-generic-font-families.html [ ImageOnlyFailure ]
    21652165fast/text/mark-matches-broken-line-rendering.html [ ImageOnlyFailure ]
    2166 fast/text/multiple-codeunit-vertical-upright.html [ ImageOnlyFailure ]
    21672166fast/text/synthetic-bold-transformed.html [ ImageOnlyFailure ]
    21682167fast/text/word-break-keep-all.html [ ImageOnlyFailure ]

  • trunk/LayoutTests/platform/mac-wk1/TestExpectations

    r261533 r261678  
    654654svg/W3C-SVG-1.1/fonts-elem-04-b.svg [ Failure ]
    655655
    656 # <rdar://problem/31893714> REGRESSION: LayoutTest fast/text/multiple-codeunit-vertical-upright.html is failing on WK1
    657 fast/text/multiple-codeunit-vertical-upright.html [ Pass ImageOnlyFailure ]
    658 
    659656# <rdar://problem/31895192> DumpRenderTree crashed in com.apple.ImageIO.framework: IIODictionary::getBoolForKey + 0
    660657http/tests/misc/slow-loading-animated-image.html [ Skip ]
Note: See TracChangeset for help on using the changeset viewer.