Changeset 261680 in webkit

Timestamp:

May 14, 2020 1:26:57 AM (4 years ago)

Author:

commit-queue@webkit.org

Message:

[GStreamer] Can't replay blob videos in web.whatsapp.com
​https://bugs.webkit.org/show_bug.cgi?id=192540

Patch by Philippe Normand <​pnormand@igalia.com> on 2020-05-14
Reviewed by Xabier Rodriguez-Calvar.

This is a variant of bug 211627 but I could reproduce it only for videos. Unfortunately I
wasn't able to write a reliable test for this.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::updateBufferingStatus): Prevent the fill timer from
running forever after buffering completed.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcMakeRequest): Don't buffer blobs, this doesn't seem useful as they're already
in memory anyway.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp (modified) (1 diff)
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-14  Philippe Normand  <pnormand@igalia.com>
+
+        [GStreamer] Can't replay blob videos in web.whatsapp.com
+        https://bugs.webkit.org/show_bug.cgi?id=192540
+
+        Reviewed by Xabier Rodriguez-Calvar.
+
+        This is a variant of bug 211627 but I could reproduce it only for videos. Unfortunately I
+        wasn't able to write a reliable test for this.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
+        (WebCore::MediaPlayerPrivateGStreamer::updateBufferingStatus): Prevent the fill timer from
+        running forever after buffering completed.
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (webKitWebSrcMakeRequest): Don't buffer blobs, this doesn't seem useful as they're already
+        in memory anyway.
+
 2020-05-06  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

@@ -2120 +2120 @@
     if (!m_didDownloadFinish)
         m_isBuffering = true;
+    else
+        m_fillTimer.stop();
 
     m_bufferingPercentage = percentage;

trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

@@ -698 +698 @@
 
         PlatformMediaResourceLoader::LoadOptions loadOptions = 0;
-        if (request.url().protocolIsBlob())
-            loadOptions |= PlatformMediaResourceLoader::LoadOption::BufferData;
         members->resource = members->loader->requestResource(ResourceRequest(request), loadOptions);
         if (members->resource) {