Changeset 261695 in webkit


Ignore:
Timestamp:
May 14, 2020 9:11:26 AM (4 years ago)
Author:
Chris Dumez
Message:

Regression(r254856) Family Health iOS app is broken due to lack for WebSQL support
https://bugs.webkit.org/show_bug.cgi?id=211896
<rdar://problem/63025045>

Reviewed by Maciej Stachowiak.

Source/WebCore:

Add RuntimeApplicationChecks function to identify Family Health app on iOS.

  • platform/RuntimeApplicationChecks.h:
  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::IOSApplication::isFamilyHealthApp):

Source/WebKitLegacy/mac:

Re-enable WebSQL support for Family Health iOS app with a linked-on-after check.

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

Source/WTF:

  • wtf/spi/darwin/dyldSPI.h:
Location:
trunk/Source
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WTF/ChangeLog

    r261661 r261695  
     12020-05-14  Chris Dumez  <cdumez@apple.com>
     2
     3        Regression(r254856) Family Health iOS app is broken due to lack for WebSQL support
     4        https://bugs.webkit.org/show_bug.cgi?id=211896
     5        <rdar://problem/63025045>
     6
     7        Reviewed by Maciej Stachowiak.
     8
     9        * wtf/spi/darwin/dyldSPI.h:
     10
    1112020-05-13  Ross Kirsling  <ross.kirsling@sony.com>
    212
  • trunk/Source/WTF/wtf/spi/darwin/dyldSPI.h

    r258564 r261695  
    5454#endif
    5555
     56#ifndef DYLD_IOS_VERSION_14_0
     57#define DYLD_IOS_VERSION_14_0 0x000e0000
     58#endif
     59
    5660#ifndef DYLD_MACOSX_VERSION_10_13
    5761#define DYLD_MACOSX_VERSION_10_13 0x000A0D00
     
    9094#define DYLD_IOS_VERSION_13_2 0x000D0200
    9195#define DYLD_IOS_VERSION_13_4 0x000D0400
     96#define DYLD_IOS_VERSION_14_0 0x000e0000
    9297
    9398#define DYLD_MACOSX_VERSION_10_11 0x000A0B00
  • trunk/Source/WebCore/ChangeLog

    r261694 r261695  
     12020-05-14  Chris Dumez  <cdumez@apple.com>
     2
     3        Regression(r254856) Family Health iOS app is broken due to lack for WebSQL support
     4        https://bugs.webkit.org/show_bug.cgi?id=211896
     5        <rdar://problem/63025045>
     6
     7        Reviewed by Maciej Stachowiak.
     8
     9        Add RuntimeApplicationChecks function to identify Family Health app on iOS.
     10
     11        * platform/RuntimeApplicationChecks.h:
     12        * platform/cocoa/RuntimeApplicationChecksCocoa.mm:
     13        (WebCore::IOSApplication::isFamilyHealthApp):
     14
    1152020-05-14  Andres Gonzalez  <andresg_22@apple.com>
    216
  • trunk/Source/WebCore/platform/RuntimeApplicationChecks.h

    r261180 r261695  
    8888bool isMobileStore();
    8989WEBCORE_EXPORT bool isJesusCalling();
     90WEBCORE_EXPORT bool isFamilyHealthApp();
    9091bool isSpringBoard();
    9192WEBCORE_EXPORT bool isWebProcess();
  • trunk/Source/WebCore/platform/cocoa/RuntimeApplicationChecksCocoa.mm

    r261180 r261695  
    256256}
    257257
     258bool IOSApplication::isFamilyHealthApp()
     259{
     260    static bool isFamilyHealthApp = applicationBundleStartsWith("com.wildflowerhealth.Grow"_s) || applicationBundleStartsWith("com.wildflowerhealth.UGROW");
     261    return isFamilyHealthApp;
     262}
     263
    258264bool IOSApplication::isMobileStore()
    259265{
  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r261586 r261695  
     12020-05-14  Chris Dumez  <cdumez@apple.com>
     2
     3        Regression(r254856) Family Health iOS app is broken due to lack for WebSQL support
     4        https://bugs.webkit.org/show_bug.cgi?id=211896
     5        <rdar://problem/63025045>
     6
     7        Reviewed by Maciej Stachowiak.
     8
     9        Re-enable WebSQL support for Family Health iOS app with a linked-on-after check.
     10
     11        * WebView/WebPreferences.mm:
     12        (+[WebPreferences initialize]):
     13
    1142020-05-12  Chris Dumez  <cdumez@apple.com>
    215
  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm

    r261074 r261695  
    397397    bool requiresPlaysInlineAttribute = !allowsInlineMediaPlayback;
    398398    bool attachmentElementEnabled = IOSApplication::isMobileMail();
    399     bool webSQLEnabled = IOSApplication::isJesusCalling() && applicationSDKVersion() <= DYLD_IOS_VERSION_12_2;
     399    bool webSQLEnabled = (IOSApplication::isFamilyHealthApp() || IOSApplication::isJesusCalling()) && applicationSDKVersion() < DYLD_IOS_VERSION_14_0;
    400400#endif
    401401
Note: See TracChangeset for help on using the changeset viewer.