Changeset 261797 in webkit

Timestamp:

May 17, 2020 10:15:07 PM (4 years ago)

Author:

Lauro Moura

Message:

[JSC] Silence unused-but-set-parameter warnings for older compilers
​https://bugs.webkit.org/show_bug.cgi?id=212006

Reviewed by Mark Lam.

GCC up to 9.x will emit unused-but-set-parameter for the sources
parameter when NumberOfRegisters is zero (the if block is eliminated)
and for destinations when also ASSERT_ENABLED is false.

• jit/CCallHelpers.h:

(JSC::CCallHelpers::setupStubArgs):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• jit/CCallHelpers.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-05-17  Lauro Moura  <lmoura@igalia.com>
+
+        [JSC] Silence unused-but-set-parameter warnings for older compilers
+        https://bugs.webkit.org/show_bug.cgi?id=212006
+
+        Reviewed by Mark Lam.
+
+        GCC up to 9.x will emit unused-but-set-parameter for the sources
+        parameter when NumberOfRegisters is zero (the if block is eliminated)
+        and for destinations when also ASSERT_ENABLED is false.
+
+        * jit/CCallHelpers.h:
+        (JSC::CCallHelpers::setupStubArgs):
+
 2020-05-16  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/Source/JavaScriptCore/jit/CCallHelpers.h

@@ -106 +106 @@
                     pairs.append(std::make_pair(sources[i], destinations[i]));
             }
+        } else {
+            // Silence some older compilers (GCC up to 9.X) about unused but set parameters.
+            UNUSED_PARAM(sources);
+            UNUSED_PARAM(destinations);
         }