Changeset 261839 in webkit

Timestamp:

May 18, 2020 4:40:06 PM (4 years ago)

Author:

Peng Liu

Message:

Add a quirk to allow an embedded Twitter video to play with one tapping
​https://bugs.webkit.org/show_bug.cgi?id=211932

Reviewed by Maciej Stachowiak.

• html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted const):
Need to check the topDocument for the existence of user interactions.
(WebCore::MediaElementSession::updateMediaUsageIfChanged): Ditto.

• page/Quirks.cpp:

(WebCore::Quirks::needsPerDocumentAutoplayBehavior const):
Add the missing needsQuirks() checking.
(WebCore::Quirks::shouldAutoplayForArbitraryUserGesture const):
Add a the quirk for twitter.com.

• platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::sessionWillBeginPlayback):
Clarify the log message.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/MediaElementSession.cpp (modified) (2 diffs)
• page/Quirks.cpp (modified) (2 diffs)
• platform/audio/ios/MediaSessionManagerIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-18  Peng Liu  <peng.liu6@apple.com>
+
+        Add a quirk to allow an embedded Twitter video to play with one tapping
+        https://bugs.webkit.org/show_bug.cgi?id=211932
+
+        Reviewed by Maciej Stachowiak.
+
+        * html/MediaElementSession.cpp:
+        (WebCore::MediaElementSession::playbackPermitted const):
+        Need to check the topDocument for the existence of user interactions.
+        (WebCore::MediaElementSession::updateMediaUsageIfChanged): Ditto.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::needsPerDocumentAutoplayBehavior const):
+        Add the missing needsQuirks() checking.
+        (WebCore::Quirks::shouldAutoplayForArbitraryUserGesture const):
+        Add a the quirk for twitter.com.
+
+        * platform/audio/ios/MediaSessionManagerIOS.mm:
+        (WebCore::MediaSessionManageriOS::sessionWillBeginPlayback):
+        Clarify the log message.
+
 2020-05-18  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/html/MediaElementSession.cpp

@@ -317 +317 @@
         return { };
 
-    if (document.hasHadUserInteraction() && document.quirks().shouldAutoplayForArbitraryUserGesture())
+    if (topDocument.hasHadUserInteraction() && document.quirks().shouldAutoplayForArbitraryUserGesture())
         return { };
 
@@ -1066 +1066 @@
         pageExplicitlyAllowsElementToAutoplayInline(m_element),
         requiresFullscreenForVideoPlayback() && !fullscreenPermitted(),
-        document.hasHadUserInteraction() && document.quirks().shouldAutoplayForArbitraryUserGesture(),
+        document.topDocument().hasHadUserInteraction() && document.quirks().shouldAutoplayForArbitraryUserGesture(),
         isVideo && hasBehaviorRestriction(RequireUserGestureForVideoRateChange) && !processingUserGesture,
         isAudio && hasBehaviorRestriction(RequireUserGestureForAudioRateChange) && !processingUserGesture && !m_element.muted() && m_element.volume(),

trunk/Source/WebCore/page/Quirks.cpp

@@ -111 +111 @@
     return needsQuirks() && allowedAutoplayQuirks(*m_document).contains(AutoplayQuirk::PerDocumentAutoplayBehavior);
 #else
+    if (!needsQuirks())
+        return false;
+
     auto host = m_document->topDocument().url().host();
     return equalLettersIgnoringASCIICase(host, "netflix.com") || host.endsWithIgnoringASCIICase(".netflix.com");
@@ -121 +124 @@
     return needsQuirks() && allowedAutoplayQuirks(*m_document).contains(AutoplayQuirk::ArbitraryUserGestures);
 #else
-    return false;
+    if (!needsQuirks())
+        return false;
+
+    auto host = m_document->url().host();
+    return equalLettersIgnoringASCIICase(host, "twitter.com") || host.endsWithIgnoringASCIICase(".twitter.com");
 #endif
 }

trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm

@@ -132 +132 @@
     }
 
-    ALWAYS_LOG(LOGIDENTIFIER, m_playbackTargetSupportsAirPlayVideo);
+    ALWAYS_LOG(LOGIDENTIFIER, "Playback Target Supports AirPlay Video = ", m_playbackTargetSupportsAirPlayVideo);
     if (m_playbackTargetSupportsAirPlayVideo)
         session.setPlaybackTarget(*m_playbackTarget.copyRef());