Changeset 261861 in webkit

Timestamp:

May 19, 2020 9:00:31 AM (4 years ago)

Author:

Antti Koivisto

Message:

Animation of font-size with rem values is incorrect
​https://bugs.webkit.org/show_bug.cgi?id=194765
<rdar://problem/48171742>

Reviewed by Antoine Quint.

Source/WebCore:

Test: animations/keyframe-rem-unit.html

'rem' computation fails on first style resolution because the document element style is not available.

• style/StyleResolver.cpp:

(WebCore::Style::Resolver::styleForKeyframe):

Provide the override value, needed because the style can't be found from DOM tree yet.

LayoutTests:

• animations/keyframe-rem-unit-expected.html: Added.
• animations/keyframe-rem-unit.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/animations/keyframe-rem-unit-expected.html (added)
• LayoutTests/animations/keyframe-rem-unit.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/style/StyleResolver.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-05-19  Antti Koivisto  <antti@apple.com>
+
+        Animation of font-size with rem values is incorrect
+        https://bugs.webkit.org/show_bug.cgi?id=194765
+        <rdar://problem/48171742>
+
+        Reviewed by Antoine Quint.
+
+        * animations/keyframe-rem-unit-expected.html: Added.
+        * animations/keyframe-rem-unit.html: Added.
+
 2020-05-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-19  Antti Koivisto  <antti@apple.com>
+
+        Animation of font-size with rem values is incorrect
+        https://bugs.webkit.org/show_bug.cgi?id=194765
+        <rdar://problem/48171742>
+
+        Reviewed by Antoine Quint.
+
+        Test: animations/keyframe-rem-unit.html
+
+        'rem' computation fails on first style resolution because the document element style is not available.
+
+        * style/StyleResolver.cpp:
+        (WebCore::Style::Resolver::styleForKeyframe):
+
+        Provide the override value, needed because the style can't be found from DOM tree yet.
+
 2020-05-19  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/style/StyleResolver.cpp

@@ -261 +261 @@
     result.authorDeclarations.append({ &keyframe->properties() });
 
-    auto state = State(element, nullptr);
+    auto state = State(element, nullptr, m_overrideDocumentElementStyle);
 
     state.setStyle(RenderStyle::clonePtr(*elementStyle));