Changeset 261865 in webkit

Timestamp:

May 19, 2020 9:21:39 AM (4 years ago)

Author:

Brent Fulgham

Message:

REGRESSION(r243149): createMediaElementSource not working
​https://bugs.webkit.org/show_bug.cgi?id=211394
<rdar://problem/62866132>

Reviewed by Per Arne Vollan.

I removed access to some Audio services in r243149, because we believed they were already
blocked by a global deny command. However, Sandbox rules override generic rules with
explicit rules, so the imported sandbox rules were not being blocked.

This patch re-adds the rules needed to support these audio routines on iOS hardware.

• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::mediaRelatedMachServices):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (modified) (1 diff)
• UIProcess/Cocoa/WebProcessPoolCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-05-19  Brent Fulgham  <bfulgham@apple.com>
+
+        REGRESSION(r243149): createMediaElementSource not working
+        https://bugs.webkit.org/show_bug.cgi?id=211394
+        <rdar://problem/62866132>
+
+        Reviewed by Per Arne Vollan.
+
+        I removed access to some Audio services in r243149, because we believed they were already
+        blocked by a global deny command. However, Sandbox rules override generic rules with
+        explicit rules, so the imported sandbox rules were not being blocked.
+
+        This patch re-adds the rules needed to support these audio routines on iOS hardware.
+
+        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::mediaRelatedMachServices):
+
 2020-05-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb

@@ -956 +956 @@
 
             ;;; FIXME(207716): The following should be removed when the GPU process is complete
-            "com.apple.airplay.apsynccontroller.xpc" "com.apple.audio.AURemoteIOServer" "com.apple.audio.AudioComponentRegistrar"
-            "com.apple.audio.AudioComponentRegistrar" "com.apple.audio.AudioSession" "com.apple.coremedia.admin" "com.apple.coremedia.asset.xpc"
+            "com.apple.airplay.apsynccontroller.xpc" "com.apple.audio.AURemoteIOServer" "com.apple.audio.AudioComponentPrefs" "com.apple.audio.AudioComponentRegistrar"
+            "com.apple.audio.AudioQueueServer" "com.apple.audio.AudioSession" "com.apple.coremedia.admin" "com.apple.coremedia.asset.xpc"
             "com.apple.coremedia.assetimagegenerator.xpc" "com.apple.coremedia.audiodeviceclock.xpc" "com.apple.coremedia.audioprocessingtap.xpc"
             "com.apple.coremedia.capturesession" "com.apple.coremedia.capturesource" "com.apple.coremedia.compressionsession" "com.apple.coremedia.cpe.xpc"

trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

@@ -217 +217 @@
     ASSERT(isMainThread());
     static const auto services = makeNeverDestroyed(Vector<String> {
-        "com.apple.audio.AudioComponentRegistrar", "com.apple.coremedia.endpoint.xpc",
+        "com.apple.audio.AudioComponentPrefs", "com.apple.audio.AudioComponentRegistrar",
+        "com.apple.audio.AudioQueueServer", "com.apple.coremedia.endpoint.xpc",
         "com.apple.coremedia.routediscoverer.xpc", "com.apple.coremedia.routingcontext.xpc",
         "com.apple.coremedia.volumecontroller.xpc", "com.apple.accessibility.mediaaccessibilityd",