Changeset 261871 in webkit

Timestamp:

May 19, 2020 11:06:15 AM (4 years ago)

Author:

clopez@igalia.com

Message:

[buildbot][GTK][WPE] Pass --verbose flag when running JavaScriptCore tests
​https://bugs.webkit.org/show_bug.cgi?id=212088

Reviewed by Philippe Normand.

Pass the "--verbose" flag to run-javascriptcore-tests also for GTK and WPE.
Also change the way we are currently passing "--memory-limited" to make
it more obvious that this is needed for all Linux bots (GTK+WPE+JSCOnly).

• BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunJavaScriptCoreTests.start):
(RunRemoteJavaScriptCoreTests.start):

Location:

trunk/Tools

Files:

• BuildSlaveSupport/build.webkit.org-config/steps.py (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/BuildSlaveSupport/build.webkit.org-config/steps.py

@@ -382 +382 @@
         # Currently run-javascriptcore-test doesn't support run javascript core test binaries list below remotely
         if architecture in ['mips', 'armv7', 'aarch64']:
-            self.command += ['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi', '--verbose']
+            self.command += ['--no-testmasm', '--no-testair', '--no-testb3', '--no-testdfg', '--no-testapi']
         # Linux bots have currently problems with JSC tests that try to use large amounts of memory.
         # Check: https://bugs.webkit.org/show_bug.cgi?id=175140
-        if platform in ('gtk', 'wpe'):
-            self.setCommand(self.command + ['--memory-limited'])
+        if platform in ('gtk', 'wpe', 'jsc-only'):
+            self.setCommand(self.command + ['--memory-limited', '--verbose'])
         # WinCairo uses the Windows command prompt, not Cygwin.
         elif platform == 'wincairo':
@@ -415 +415 @@
 class RunRemoteJavaScriptCoreTests(RunJavaScriptCoreTests):
     def start(self):
-        self.setCommand(self.command + ["--memory-limited", "--remote-config-file", "../../remote-jsc-tests-config.json"])
+        self.setCommand(self.command + ["--remote-config-file", "../../remote-jsc-tests-config.json"])
         return RunJavaScriptCoreTests.start(self)
 

trunk/Tools/ChangeLog

@@ +1 @@
+2020-05-19  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        [buildbot][GTK][WPE] Pass --verbose flag when running JavaScriptCore tests
+        https://bugs.webkit.org/show_bug.cgi?id=212088
+
+        Reviewed by Philippe Normand.
+
+        Pass the "--verbose" flag to run-javascriptcore-tests also for GTK and WPE.
+        Also change the way we are currently passing "--memory-limited" to make
+        it more obvious that this is needed for all Linux bots (GTK+WPE+JSCOnly).
+
+        * BuildSlaveSupport/build.webkit.org-config/steps.py:
+        (RunJavaScriptCoreTests.start):
+        (RunRemoteJavaScriptCoreTests.start):
+
 2020-05-19  Michael Catanzaro  <mcatanzaro@gnome.org>