Changeset 261906 in webkit

Timestamp:

May 19, 2020 10:44:29 PM (4 years ago)

Author:

Wenson Hsieh

Message:

REGRESSION (r258919): fast/events/ios/key-events-comprehensive/key-events-control tests are failing
​https://bugs.webkit.org/show_bug.cgi?id=212124
<rdar://problem/60893744>

Reviewed by Tim Horton.

After the changes in r258919, WKContentView's text input traits report that we're in a single line input, even
when there is no editable focused element. This prevents UIKit from allowing WebKit to handle the CTRL + M
key command, which is interpreted at the system level as inserting a line break in a multi-line editable area.

It seems odd to consider ourselves in a single line input when there isn't even an editable element focused
element; for now, we can fix these failing tests by just going with the default value for the text input traits'
setIsSingleLineDocument property, but not explicitly setting it to either NO or YES when no element is
focused.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView textInputTraits]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-05-19  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        REGRESSION (r258919): fast/events/ios/key-events-comprehensive/key-events-control tests are failing
+        https://bugs.webkit.org/show_bug.cgi?id=212124
+        <rdar://problem/60893744>
+
+        Reviewed by Tim Horton.
+
+        After the changes in r258919, WKContentView's text input traits report that we're in a single line input, even
+        when there is no editable focused element. This prevents UIKit from allowing WebKit to handle the `CTRL + M`
+        key command, which is interpreted at the system level as inserting a line break in a multi-line editable area.
+
+        It seems odd to consider ourselves in a single line input when there isn't even an editable element focused
+        element; for now, we can fix these failing tests by just going with the default value for the text input traits'
+        `setIsSingleLineDocument` property, but not explicitly setting it to either `NO` or `YES` when no element is
+        focused.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView textInputTraits]):
+
 2020-05-19  Sam Weinig  <weinig@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -5062 +5062 @@
     case WebKit::InputType::Email:
     case WebKit::InputType::Month:
-    case WebKit::InputType::None:
     case WebKit::InputType::Number:
     case WebKit::InputType::NumberPad:
@@ -5074 +5073 @@
     case WebKit::InputType::Week:
         [_traits setIsSingleLineDocument:YES];
+        break;
+    case WebKit::InputType::None:
         break;
     }