Changeset 261927 in webkit


Ignore:
Timestamp:
May 20, 2020 9:29:50 AM (4 years ago)
Author:
graouts@webkit.org
Message:

[Web Animations] Animation engine should not wake up every tick for steps timing functions
https://bugs.webkit.org/show_bug.cgi?id=212103
<rdar://problem/62737868>

Unreviewed. Clean up some stray FIXMEs mistakenly commited in the previous commit.

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::createAnimatedElementUpdate):

Location:
trunk/Source/WebCore
Files:
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r261926 r261927  
     12020-05-20  Antoine Quint  <graouts@apple.com>
     2
     3        [Web Animations] Animation engine should not wake up every tick for steps timing functions
     4        https://bugs.webkit.org/show_bug.cgi?id=212103
     5        <rdar://problem/62737868>
     6
     7        Unreviewed. Clean up some stray FIXMEs mistakenly commited in the previous commit.
     8
     9        * animation/AnimationTimeline.cpp:
     10        (WebCore::AnimationTimeline::updateCSSTransitionsForElementAndProperty):
     11        * style/StyleTreeResolver.cpp:
     12        (WebCore::Style::TreeResolver::createAnimatedElementUpdate):
     13
    1142020-05-20  Antoine Quint  <graouts@apple.com>
    215
  • trunk/Source/WebCore/animation/AnimationTimeline.cpp

    r261926 r261927  
    400400            // start value of the transition shoud be to make sure that we don't account for animated values that would have been blended onto
    401401            // the style applied during the last style resolution.
    402 
    403             // FIXME: NO. We should be applying animations with the current time.
    404 
    405402            if (auto* unanimatedStyle = keyframeEffect->unanimatedStyle())
    406403                return RenderStyle::clone(*unanimatedStyle);
  • trunk/Source/WebCore/style/StyleTreeResolver.cpp

    r261926 r261927  
    318318                m_document.timeline().updateCSSTransitionsForElement(element, *oldStyle, *newStyle);
    319319
    320             // FIXME: Maybe need to do this first such that CSS Transitions are aware of newly created or canceled animations
    321320            if ((oldStyle && oldStyle->hasAnimations()) || newStyle->hasAnimations())
    322321                m_document.timeline().updateCSSAnimationsForElement(element, oldStyle, *newStyle);
Note: See TracChangeset for help on using the changeset viewer.