Changeset 261935 in webkit

Timestamp:

May 20, 2020 11:37:47 AM (4 years ago)

Author:

Kate Cheney

Message:

REGRESSION (r261892) [ Mac Debug ] 4 API tests failing related to ResourceLoadStatistics
​https://bugs.webkit.org/show_bug.cgi?id=212153
<rdar://problem/63452541>

Reviewed by Sihui Liu.

Accidentally deleted necessary reset() call for a SQLite statement
when converting stored statements to SQLiteStatementAutoResetScope in
​https://trac.webkit.org/changeset/261892/webkit.

This statement is used in a loop with multiple bind() calls so it must be reset.

• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:

(WebKit::ResourceLoadStatisticsDatabaseStore::checkForMissingTablesInSchema):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-05-20  Kate Cheney  <katherine_cheney@apple.com>
+
+        REGRESSION (r261892) [ Mac Debug ] 4 API tests failing related to ResourceLoadStatistics
+        https://bugs.webkit.org/show_bug.cgi?id=212153
+        <rdar://problem/63452541>
+
+        Reviewed by Sihui Liu.
+
+        Accidentally deleted necessary reset() call for a SQLite statement
+        when converting stored statements to SQLiteStatementAutoResetScope in
+        https://trac.webkit.org/changeset/261892/webkit.
+
+        This statement is used in a loop with multiple bind() calls so it must be reset.
+
+        * NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:
+        (WebKit::ResourceLoadStatisticsDatabaseStore::checkForMissingTablesInSchema):
+
 2020-05-20  Eric Carlson  <eric.carlson@apple.com>
 

trunk/Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp

@@ -353 +353 @@
             missingTables.append(String(table));
         }
+        statement.reset();
     }
     if (missingTables.isEmpty())