Changeset 261994 in webkit
- Timestamp:
- May 21, 2020 7:28:06 AM (4 years ago)
- Location:
- trunk
- Files:
-
- 5 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r261992 r261994 1 2020-05-21 Zalan Bujtas <zalan@apple.com> 2 3 [ macOS debug ] REGRESSION: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html is a flaky crash 4 https://bugs.webkit.org/show_bug.cgi?id=212139 5 <rdar://problem/63447683> 6 7 Reviewed by Antti Koivisto. 8 9 * platform/mac/TestExpectations: 10 1 11 2020-05-21 Zan Dobersek <zdobersek@igalia.com> 2 12 -
trunk/LayoutTests/platform/mac/TestExpectations
r261952 r261994 1960 1960 webkit.org/b/211891 imported/w3c/web-platform-tests/css/css-flexbox/flexbox_direction-row-reverse.html [ ImageOnlyFailure ] 1961 1961 1962 webkit.org/b/212139 fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html [ Skip ]1963 1964 1962 webkit.org/b/212165 http/tests/resourceLoadStatistics/telemetry-generation-basic-functionality-database.html [ Pass Failure ] -
trunk/Source/WebCore/ChangeLog
r261991 r261994 1 2020-05-21 Zalan Bujtas <zalan@apple.com> 2 3 [ macOS debug ] REGRESSION: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html is a flaky crash 4 https://bugs.webkit.org/show_bug.cgi?id=212139 5 <rdar://problem/63447683> 6 7 Reviewed by Antti Koivisto. 8 9 Uninitialized row baseline value caused unexpected cell height in nested tables. 10 11 * layout/tableformatting/TableFormattingContext.cpp: 12 (WebCore::Layout::TableFormattingContext::setUsedGeometryForRows): 13 * layout/tableformatting/TableGrid.h: 14 1 15 2020-05-21 Zalan Bujtas <zalan@apple.com> 2 16 -
trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp
r261991 r261994 150 150 151 151 auto& columns = grid.columns(); 152 Vector<InlineLayoutUnit> rowBaselines(rows.size() );152 Vector<InlineLayoutUnit> rowBaselines(rows.size(), 0); 153 153 // Now that cells are laid out, let's compute the row baselines. 154 154 for (size_t rowIndex = 0; rowIndex < rows.size(); ++rowIndex) { -
trunk/Source/WebCore/layout/tableformatting/TableGrid.h
r261919 r261994 175 175 SlotPosition m_position; 176 176 CellSpan m_span; 177 InlineLayoutUnit m_baselineOffset ;177 InlineLayoutUnit m_baselineOffset { 0 }; 178 178 }; 179 179
Note: See TracChangeset
for help on using the changeset viewer.