Changeset 261994 in webkit


Ignore:
Timestamp:
May 21, 2020 7:28:06 AM (4 years ago)
Author:
Alan Bujtas
Message:

[ macOS debug ] REGRESSION: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=212139
<rdar://problem/63447683>

Reviewed by Antti Koivisto.

Source/WebCore:

Uninitialized row baseline value caused unexpected cell height in nested tables.

  • layout/tableformatting/TableFormattingContext.cpp:

(WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):

  • layout/tableformatting/TableGrid.h:

LayoutTests:

  • platform/mac/TestExpectations:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r261992 r261994  
     12020-05-21  Zalan Bujtas  <zalan@apple.com>
     2
     3        [ macOS debug ] REGRESSION: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html is a flaky crash
     4        https://bugs.webkit.org/show_bug.cgi?id=212139
     5        <rdar://problem/63447683>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        * platform/mac/TestExpectations:
     10
    1112020-05-21  Zan Dobersek  <zdobersek@igalia.com>
    212
  • trunk/LayoutTests/platform/mac/TestExpectations

    r261952 r261994  
    19601960webkit.org/b/211891 imported/w3c/web-platform-tests/css/css-flexbox/flexbox_direction-row-reverse.html [ ImageOnlyFailure ]
    19611961
    1962 webkit.org/b/212139 fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html [ Skip ]
    1963 
    19641962webkit.org/b/212165 http/tests/resourceLoadStatistics/telemetry-generation-basic-functionality-database.html [ Pass Failure ]
  • trunk/Source/WebCore/ChangeLog

    r261991 r261994  
     12020-05-21  Zalan Bujtas  <zalan@apple.com>
     2
     3        [ macOS debug ] REGRESSION: fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html is a flaky crash
     4        https://bugs.webkit.org/show_bug.cgi?id=212139
     5        <rdar://problem/63447683>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        Uninitialized row baseline value caused unexpected cell height in nested tables.
     10
     11        * layout/tableformatting/TableFormattingContext.cpp:
     12        (WebCore::Layout::TableFormattingContext::setUsedGeometryForRows):
     13        * layout/tableformatting/TableGrid.h:
     14
    1152020-05-21  Zalan Bujtas  <zalan@apple.com>
    216
  • trunk/Source/WebCore/layout/tableformatting/TableFormattingContext.cpp

    r261991 r261994  
    150150
    151151    auto& columns = grid.columns();
    152     Vector<InlineLayoutUnit> rowBaselines(rows.size());
     152    Vector<InlineLayoutUnit> rowBaselines(rows.size(), 0);
    153153    // Now that cells are laid out, let's compute the row baselines.
    154154    for (size_t rowIndex = 0; rowIndex < rows.size(); ++rowIndex) {
  • trunk/Source/WebCore/layout/tableformatting/TableGrid.h

    r261919 r261994  
    175175        SlotPosition m_position;
    176176        CellSpan m_span;
    177         InlineLayoutUnit m_baselineOffset;
     177        InlineLayoutUnit m_baselineOffset { 0 };
    178178    };
    179179
Note: See TracChangeset for help on using the changeset viewer.