Changeset 262015 in webkit

Timestamp:

May 21, 2020 11:02:57 AM (4 years ago)

Author:

sihui_liu@apple.com

Message:

SQLite database fails to close in SQLiteIDBBackingStore::databaseNameFromFile
​https://bugs.webkit.org/show_bug.cgi?id=212090

Reviewed by Darin Adler.

We should finish SQLite statement before closing database.

• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromFile):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/indexeddb/server/SQLiteIDBBackingStore.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-05-21  Sihui Liu  <sihui_liu@apple.com>
+
+        SQLite database fails to close in SQLiteIDBBackingStore::databaseNameFromFile
+        https://bugs.webkit.org/show_bug.cgi?id=212090
+
+        Reviewed by Darin Adler.
+
+        We should finish SQLite statement before closing database.
+
+        * Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
+        (WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromFile):
+
 2020-05-21  Doug Kelly  <dougk@apple.com>
 

trunk/Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp

@@ -922 +922 @@
     if (!database.tableExists("IDBDatabaseInfo"_s)) {
         LOG_ERROR("Could not find IDBDatabaseInfo table and get database name(%i) - %s", database.lastError(), database.lastErrorMsg());
-        database.close();
         return { };
     }
     SQLiteStatement sql(database, "SELECT value FROM IDBDatabaseInfo WHERE key = 'DatabaseName';");
-    auto databaseName = sql.getColumnText(0);
-    database.close();
-    return databaseName;
+    return sql.getColumnText(0);
 }