Changeset 262019 in webkit

Timestamp:

May 21, 2020 12:00:26 PM (4 years ago)

Author:

Chris Dumez

Message:

compositing/show-composited-iframe-on-back-button.html is a flaky timing out
​https://bugs.webkit.org/show_bug.cgi?id=212221
<rdar://problem/63493074>

Reviewed by Alex Christensen.

I am unable to reproduce the flakiness locally so this is a speculative fix.
Stop using testRunner.queueLoad() / testRunner.queueBackNavigation() and instead
just navigate to page-cache-helper.html in JS, by setting window.location.
Also, call testRunner.waitUntilDone() and call testRunner.notifyDone() when the
page comes out of the back/forward cache.

• compositing/show-composited-iframe-on-back-button.html:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• compositing/show-composited-iframe-on-back-button.html (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2020-05-21  Chris Dumez  <cdumez@apple.com>
+
+        compositing/show-composited-iframe-on-back-button.html is a flaky timing out
+        https://bugs.webkit.org/show_bug.cgi?id=212221
+        <rdar://problem/63493074>
+
+        Reviewed by Alex Christensen.
+
+        I am unable to reproduce the flakiness locally so this is a speculative fix.
+        Stop using testRunner.queueLoad() / testRunner.queueBackNavigation() and instead
+        just navigate to page-cache-helper.html in JS, by setting window.location.
+        Also, call testRunner.waitUntilDone() and call testRunner.notifyDone() when the
+        page comes out of the back/forward cache.
+
+        * compositing/show-composited-iframe-on-back-button.html:
+
 2020-05-21  Jacob Uphoff  <jacob_uphoff@apple.com>
 

trunk/LayoutTests/compositing/show-composited-iframe-on-back-button.html

@@ -6 +6 @@
 <link rel="stylesheet" href="resources/show-composited-iframe-on-back-button.css">
 <script>
-function handleOnPageShow(pageTransitionEvent)
-{
-    console.assert(window.testRunner);
-    if (pageTransitionEvent.persisted)
-        return;
+if (window.testRunner)
+    testRunner.waitUntilDone();
 
-    // First time the page has been loaded.
-    testRunner.queueLoad("about:blank");
-    testRunner.queueBackNavigation(1);
+onpageshow = (pageTransitionEvent) => {
+    if (pageTransitionEvent.persisted) {
+        if (window.testRunner)
+            testRunner.notifyDone();
+    }
 }
 
-if (window.testRunner)
-    window.onpageshow = handleOnPageShow;
+onload = () => {
+    setTimeout(() => {
+        window.location = "../fast/history/resources/page-cache-helper.html";
+    }, 0);
+}
+
 </script>
 </head>