Changeset 262060 in webkit


Ignore:
Timestamp:
May 22, 2020 9:42:58 AM (4 years ago)
Author:
mmaxfield@apple.com
Message:

[Cocoa] fast/text/font-collection.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=212172
<rdar://problem/63466187>

Unreviewed.

The test is failing because the collection font file placed one of its table
directories after the table data. This is a valid file, so this patch doesn't
delete the test, but it also duplicates the test with a new collection font
file that doesn't have this construction. The duplicate test should pass on
all OSes.

  • fast/text/font-collection-2-expected.html: Copied from LayoutTests/fast/text/font-collection.html.
  • fast/text/font-collection-2.html: Added. Add some extra characters just to make sure things are working properly.
  • fast/text/font-collection-expected.html:
  • fast/text/font-collection.html: Ditto.
  • fast/text/resources/collection2.ttc: Added.
  • platform/ios/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
Location:
trunk/LayoutTests
Files:
3 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r262059 r262060  
     12020-05-22  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        [Cocoa] fast/text/font-collection.html is failing
     4        https://bugs.webkit.org/show_bug.cgi?id=212172
     5        <rdar://problem/63466187>
     6
     7        Unreviewed.
     8
     9        The test is failing because the collection font file placed one of its table
     10        directories after the table data. This is a valid file, so this patch doesn't
     11        delete the test, but it also duplicates the test with a new collection font
     12        file that doesn't have this construction. The duplicate test should pass on
     13        all OSes.
     14
     15        * fast/text/font-collection-2-expected.html: Copied from LayoutTests/fast/text/font-collection.html.
     16        * fast/text/font-collection-2.html: Added. Add some extra characters just to
     17          make sure things are working properly.
     18        * fast/text/font-collection-expected.html:
     19        * fast/text/font-collection.html: Ditto.
     20        * fast/text/resources/collection2.ttc: Added.
     21        * platform/ios/TestExpectations:
     22        * platform/mac/TestExpectations:
     23        * platform/win/TestExpectations:
     24
    1252020-05-22  Ryan Haddad  <ryanhaddad@apple.com>
    226

  • trunk/LayoutTests/fast/text/font-collection-expected.html

    r231259 r262060  
    22<html>
    33<head>
     4<style>
     5@font-face {
     6    font-family: "WebFont1";
     7    src: url("../../resources/Ahem.ttf");
     8}
     9</style>
    410</head>
    511<body>
    6 This test makes sure that font collections work correctly. The font passes if you see a letter "A" below.
    7 <div style="font: 48px 'Helvetica';">A</div>
     12This test makes sure that font collections work correctly. The font passes if you see a letter "A" followed by two squares below.
     13<div style="-webkit-font-smoothing: none;">
     14<div style="display: inline-block; width: 1px; height: 100px;"></div>
     15<div style="display: inline-block; margin: 5px; font: 48px 'Helvetica';">A</div>
     16<div style="display: inline-block; margin: 5px; font: 48px 'WebFont1';">A</div>
     17<div style="display: inline-block; margin: 5px; font: 48px 'WebFont1';">B</div>
     18</div>
    819</body>
    920</html>

  • trunk/LayoutTests/fast/text/font-collection.html

    r231259 r262060  
    1414</head>
    1515<body>
    16 This test makes sure that font collections work correctly. The font passes if you see a letter "A" below.
    17 <div style="font: 48px 'WebFont1', 'Helvetica';">A</div>
     16This test makes sure that font collections work correctly. The font passes if you see a letter "A" followed by two squares below.
     17<div style="-webkit-font-smoothing: none;">
     18<div style="display: inline-block; width: 1px; height: 100px;"></div>
     19<div style="display: inline-block; margin: 5px; font: 48px 'WebFont1', 'Helvetica';">A</div>
     20<div style="display: inline-block; margin: 5px; font: 48px 'WebFont2', 'Helvetica';">A</div>
     21<div style="display: inline-block; margin: 5px; font: 48px 'WebFont1', 'Helvetica';">B</div>
     22</div>
    1823</body>
    1924</html>

  • trunk/LayoutTests/platform/ios/TestExpectations

    r262056 r262060  
    32133213
    32143214# <rdar://problem/40172428> REGRESSION: LayoutTests fast/text/font-collection.html and fast/text/woff2.html are failing
    3215 fast/text/font-collection.html [ ImageOnlyFailure ]
     3215webkit.org/b/212172 fast/text/font-collection.html [ ImageOnlyFailure ]
    32163216
    32173217# <rdar://problem/41546587> REGRESSION: LayoutTest compositing/contents-scale/non-decomposable-matrix.html is failing

  • trunk/LayoutTests/platform/mac/TestExpectations

    r262056 r262060  
    16791679
    16801680# <rdar://problem/40172428>
    1681 [ Catalina+ ] fast/text/font-collection.html [ ImageOnlyFailure ]
     1681webkit.org/b/212172 [ Catalina ] fast/text/font-collection.html [ ImageOnlyFailure ]
    16821682[ Catalina+ ] fast/text/woff2.html [ Pass ImageOnlyFailure ]
    16831683

  • trunk/LayoutTests/platform/win/TestExpectations

    r261982 r262060  
    45034503webkit.org/b/211860 fast/text/multiple-codeunit-vertical-upright.html [ Pass ImageOnlyFailure ]
    45044504webkit.org/b/211860 fast/text/multiple-codeunit-vertical-upright-2.html [ Pass ImageOnlyFailure ]
     4505webkit.org/b/212172 fast/text/font-collection.html [ ImageOnlyFailure ]
     4506webkit.org/b/212172 fast/text/font-collection-2.html [ ImageOnlyFailure ]
Note: See TracChangeset for help on using the changeset viewer.