Changeset 262071 in webkit

Timestamp:

May 22, 2020 1:33:30 PM (4 years ago)

Author:

timothy_horton@apple.com

Message:

Excessive hang time in iOS Safari under waitForDidUpdateActivityState
​https://bugs.webkit.org/show_bug.cgi?id=212272
<rdar://problem/62787789>

Reviewed by Andy Estes.

• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState):
Make the view state change timeout equivalent on iOS and macOS.

We believe that it is preferable to paint white than block the UI
process main thread for half a second. Reduce the timeout on iOS
to be the same as it has been for years on macOS.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-05-22  Tim Horton  <timothy_horton@apple.com>
+
+        Excessive hang time in iOS Safari under waitForDidUpdateActivityState
+        https://bugs.webkit.org/show_bug.cgi?id=212272
+        <rdar://problem/62787789>
+
+        Reviewed by Andy Estes.
+
+        * UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
+        (WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateActivityState):
+        Make the view state change timeout equivalent on iOS and macOS.
+
+        We believe that it is preferable to paint white than block the UI
+        process main thread for half a second. Reduce the timeout on iOS
+        to be the same as it has been for years on macOS.
+
 2020-05-22  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm

@@ -463 +463 @@
         if (id value = [[NSUserDefaults standardUserDefaults] objectForKey:@"WebKitOverrideActivityStateUpdateTimeout"])
             return Seconds([value doubleValue]);
-
-#if PLATFORM(IOS_FAMILY)
-        return Seconds::fromMilliseconds(500);
-#else
         return Seconds::fromMilliseconds(250);
-#endif
     }();