Changeset 262084 in webkit


Ignore:
Timestamp:
May 22, 2020 3:43:39 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

Make download resume workaround forgiving of changes in CFNetwork
​https://bugs.webkit.org/show_bug.cgi?id=212273

Patch by Alex Christensen <​achristensen@webkit.org> on 2020-05-22
Reviewed by Geoffrey Garen.

Source/WebCore/PAL:

  • pal/spi/cf/CFNetworkSPI.h:

Source/WebKit:

They broke my workaround. See rdar://problem/63512518

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/PAL/ChangeLog

    r262069 r262084  
     12020-05-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Make download resume workaround forgiving of changes in CFNetwork
     4        https://bugs.webkit.org/show_bug.cgi?id=212273
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        * pal/spi/cf/CFNetworkSPI.h:
     9
    1102020-05-22  Andy Estes  <aestes@apple.com>
    211

  • trunk/Source/WebCore/PAL/pal/spi/cf/CFNetworkSPI.h

    r261762 r262084  
    426426@end
    427427
    428 @interface __NSCFLocalDownloadFile
     428@interface __NSCFLocalDownloadFile : NSObject
    429429@end
    430430@interface __NSCFLocalDownloadFile ()

  • trunk/Source/WebKit/ChangeLog

    r262075 r262084  
     12020-05-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Make download resume workaround forgiving of changes in CFNetwork
     4        https://bugs.webkit.org/show_bug.cgi?id=212273
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        They broke my workaround.  See rdar://problem/63512518
     9
     10        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
     11        (-[WKNetworkSessionDelegate URLSession:downloadTask:didResumeAtOffset:expectedTotalBytes:]):
     12
    1132020-05-22  Wenson Hsieh  <wenson_hsieh@apple.com>
    214

  • trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

    r262066 r262084  
    958958#if PLATFORM(IOS_FAMILY)
    959959    // This is to work around rdar://problem/63249830
    960     downloadTask.downloadFile.skipUnlink = YES;
     960    if ([downloadTask respondsToSelector:@selector(downloadFile)] && [downloadTask.downloadFile respondsToSelector:@selector(setSkipUnlink:)])
     961        downloadTask.downloadFile.skipUnlink = YES;
    961962#endif
    962963}

  • trunk/Tools/ChangeLog

    r262068 r262084  
     12020-05-22  Alex Christensen  <achristensen@webkit.org>
     2
     3        Make download resume workaround forgiving of changes in CFNetwork
     4        https://bugs.webkit.org/show_bug.cgi?id=212273
     5
     6        Reviewed by Geoffrey Garen.
     7
     8        * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
     9
    1102020-05-22  Paulo Matos  <pmatos@igalia.com>
    211

  • trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/Download.mm

    r262018 r262084  
    11611161}
    11621162
    1163 #if HAVE(NETWORK_FRAMEWORK)
     1163// FIXME: Enable this everywhere once rdar://problem/63249830 or rdar://problem/63512518 is fixed.
     1164#if HAVE(NETWORK_FRAMEWORK) && (PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED < 140000))
    11641165
    11651166template<size_t length>
Note: See TracChangeset for help on using the changeset viewer.