Changeset 262092 in webkit

Timestamp:

May 22, 2020 8:31:22 PM (4 years ago)

Author:

ddkilzer@apple.com

Message:

WTF::isValidEnum() has a typo in static_assert making it a tautological comparison
<​https://webkit.org/b/212290>

Reviewed by Yusuke Suzuki.

• wtf/EnumTraits.h:

(WTF::isValidEnum): Use sizeof(std::underlying_type_t<E>)
instead of std::underlying_type_t<E>() to fix the bug.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/EnumTraits.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2020-05-22  David Kilzer  <ddkilzer@apple.com>
+
+        WTF::isValidEnum() has a typo in static_assert making it a tautological comparison
+        <https://webkit.org/b/212290>
+
+        Reviewed by Yusuke Suzuki.
+
+        * wtf/EnumTraits.h:
+        (WTF::isValidEnum): Use sizeof(std::underlying_type_t<E>)
+        instead of std::underlying_type_t<E>() to fix the bug.
+
 2020-05-22  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WTF/wtf/EnumTraits.h

@@ -57 +57 @@
 constexpr bool isValidEnum(T t)
 {
-    static_assert(sizeof(T) >= std::underlying_type_t<E>(), "Integral type must be at least the size of the underlying enum type");
+    static_assert(sizeof(T) >= sizeof(std::underlying_type_t<E>), "Integral type must be at least the size of the underlying enum type");
 
     return EnumValueChecker<T, typename EnumTraits<E>::values>::isValidEnum(t);