Changeset 262166 in webkit

Timestamp:

May 26, 2020 3:43:40 PM (4 years ago)

Author:

yoshiaki.jitsukawa@sony.com

Message:

[PlayStation] Enable RemoteWebInspector
​https://bugs.webkit.org/show_bug.cgi?id=212312

Reviewed by Don Olmstead.

• API/JSRemoteInspectorServer.cpp:

Fix compile error.

• PlatformPlayStation.cmake:

Add JSRemoteInspectorServer.h to the public header list.

• inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:

Set PlayStation specific socket option.

Location:

trunk/Source/JavaScriptCore

Files:

• API/JSRemoteInspectorServer.cpp (modified) (1 diff)
• ChangeLog (modified) (1 diff)
• PlatformPlayStation.cmake (modified) (2 diffs)
• inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp (modified) (2 diffs)

trunk/Source/JavaScriptCore/API/JSRemoteInspectorServer.cpp

@@ -31 +31 @@
 uint16_t JSRemoteInspectorServerStart(const char* address, uint16_t port)
 {
-    const auto& server = Inspector::RemoteInspectorServer::singleton();
+    auto& server = Inspector::RemoteInspectorServer::singleton();
     if (!server.start(address, port))
         return 0;

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2020-05-26  Yoshiaki JITSUKAWA  <yoshiaki.jitsukawa@sony.com>
+
+        [PlayStation] Enable RemoteWebInspector
+        https://bugs.webkit.org/show_bug.cgi?id=212312
+
+        Reviewed by Don Olmstead.
+
+        * API/JSRemoteInspectorServer.cpp:
+        Fix compile error.
+        * PlatformPlayStation.cmake:
+        Add JSRemoteInspectorServer.h to the public header list.
+        * inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp:
+        Set PlayStation specific socket option.
+
 2020-05-26  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/JavaScriptCore/PlatformPlayStation.cmake

@@ +1 @@
+list(APPEND JavaScriptCore_PUBLIC_FRAMEWORK_HEADERS
+    API/JSRemoteInspectorServer.h
+)
+
 list(APPEND JavaScriptCore_PRIVATE_INCLUDE_DIRECTORIES
     "${JAVASCRIPTCORE_DIR}/inspector/remote/socket"
@@ -19 +23 @@
 list(APPEND JavaScriptCore_SOURCES
     API/JSRemoteInspector.cpp
+    API/JSRemoteInspectorServer.cpp
 
     inspector/remote/RemoteAutomationTarget.cpp

trunk/Source/JavaScriptCore/inspector/remote/socket/posix/RemoteInspectorSocketPOSIX.cpp

@@ -86 +86 @@
         return WTF::nullopt;
     }
+
     error = setsockopt(fdListen, SOL_SOCKET, SO_REUSEPORT, &enabled, sizeof(enabled));
     if (error < 0) {
@@ -92 +93 @@
         return WTF::nullopt;
     }
+
+#if PLATFORM(PLAYSTATION)
+    if (setsockopt(fdListen, SOL_SOCKET, SO_USE_DEVLAN, &enabled, sizeof(enabled)) < 0) {
+        LOG_ERROR("setsocketopt() SO_USE_DEVLAN, errno = %d", errno);
+        ::close(fdListen);
+        return WTF::nullopt;
+    }
+#endif
 
     // FIXME: Support AF_INET6 connections.