Changeset 262211 in webkit


Ignore:
Timestamp:
May 27, 2020 1:15:47 PM (4 years ago)
Author:
commit-queue@webkit.org
Message:

-Wdeprecated-copy caused by Bitmap copy assignment operator
https://bugs.webkit.org/show_bug.cgi?id=212421

Patch by Michael Catanzaro <Michael Catanzaro> on 2020-05-27
Reviewed by Mark Lam.

This copy assignment operator is not needed, and causes warnings because we do not have a
corresponding copy constructor. We could add a copy constructor, but it's easiest to just
remove the copy assignment operator.

  • wtf/Bitmap.h:
Location:
trunk/Source/WTF
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WTF/ChangeLog

    r262199 r262211  
     12020-05-27  Michael Catanzaro  <mcatanzaro@gnome.org>
     2
     3        -Wdeprecated-copy caused by Bitmap copy assignment operator
     4        https://bugs.webkit.org/show_bug.cgi?id=212421
     5
     6        Reviewed by Mark Lam.
     7
     8        This copy assignment operator is not needed, and causes warnings because we do not have a
     9        corresponding copy constructor. We could add a copy constructor, but it's easiest to just
     10        remove the copy assignment operator.
     11
     12        * wtf/Bitmap.h:
     13
    1142020-05-26  Darin Adler  <darin@apple.com>
    215
  • trunk/Source/WTF/wtf/Bitmap.h

    r262167 r262211  
    125125    bool operator!=(const Bitmap&) const;
    126126
    127     void operator=(const Bitmap&);
    128127    void operator|=(const Bitmap&);
    129128    void operator&=(const Bitmap&);
     
    478477
    479478template<size_t bitmapSize, typename WordType>
    480 inline void Bitmap<bitmapSize, WordType>::operator=(const Bitmap& other)
    481 {
    482     for (size_t i = 0; i < words; ++i)
    483         bits[i] = other.bits[i];
    484 }
    485 
    486 template<size_t bitmapSize, typename WordType>
    487479inline void Bitmap<bitmapSize, WordType>::operator|=(const Bitmap& other)
    488480{
Note: See TracChangeset for help on using the changeset viewer.