Changeset 262621 in webkit

Timestamp:

Jun 5, 2020 8:47:41 AM (4 years ago)

Author:

Adrian Perez de Castro

Message:

Non-unified build fixes, early summer 2020 edition
​https://bugs.webkit.org/show_bug.cgi?id=212819

Unreviewed build fix.

Source/WebCore:

No new tests needed.

• animation/ElementAnimationRareData.cpp: Add missing RenderStyle.h header.
• animation/ElementAnimationRareData.h: Add forward declaration for RenderStyle.
• editing/TextManipulationController.cpp: Sprinkle missing HTMLNames:: prefixes.

(WebCore::shouldExtractValueForTextManipulation):
(WebCore::TextManipulationController::observeParagraphs):
(WebCore::makePositionTuple):
(WebCore::TextManipulationController::replace):

• platform/graphics/SimpleColor.h: Add missing ColorComponents.h and wtf/text/WTFString.h

headers.

• workers/service/context/ServiceWorkerThread.cpp: Add missing Logging.h header.

Source/WebKit:

• Shared/gtk/NativeWebMouseEventGtk.cpp:

(WebKit::NativeWebMouseEvent::NativeWebMouseEvent): Add missing WebCore:: namespace to
a couple of uses of WebCore::FloatSize.

• WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: Add missing Logging.h header.

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/animation/ElementAnimationRareData.cpp (modified) (1 diff)
• WebCore/animation/ElementAnimationRareData.h (modified) (1 diff)
• WebCore/editing/TextManipulationController.cpp (modified) (4 diffs)
• WebCore/platform/graphics/SimpleColor.h (modified) (1 diff)
• WebCore/workers/service/context/ServiceWorkerThread.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp (modified) (1 diff)
• WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-06-05  Adrian Perez de Castro  <aperez@igalia.com>
+
+        Non-unified build fixes, early summer 2020 edition
+        https://bugs.webkit.org/show_bug.cgi?id=212819
+
+        Unreviewed build fix.
+
+        No new tests needed.
+
+        * animation/ElementAnimationRareData.cpp: Add missing RenderStyle.h header.
+        * animation/ElementAnimationRareData.h: Add forward declaration for RenderStyle.
+        * editing/TextManipulationController.cpp: Sprinkle missing HTMLNames:: prefixes.
+        (WebCore::shouldExtractValueForTextManipulation):
+        (WebCore::TextManipulationController::observeParagraphs):
+        (WebCore::makePositionTuple):
+        (WebCore::TextManipulationController::replace):
+        * platform/graphics/SimpleColor.h: Add missing ColorComponents.h and wtf/text/WTFString.h
+        headers.
+        * workers/service/context/ServiceWorkerThread.cpp: Add missing Logging.h header.
+
 2020-06-05  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebCore/animation/ElementAnimationRareData.cpp

@@ -30 +30 @@
 #include "CSSTransition.h"
 #include "KeyframeEffectStack.h"
+#include "RenderStyle.h"
 
 namespace WebCore {

trunk/Source/WebCore/animation/ElementAnimationRareData.h

@@ -33 +33 @@
 class CSSAnimation;
 class CSSTransition;
+class RenderStyle;
 class WebAnimation;
 

trunk/Source/WebCore/editing/TextManipulationController.cpp

@@ -223 +223 @@
 static bool shouldExtractValueForTextManipulation(const HTMLInputElement& input)
 {
-    if (input.isSearchField() || equalIgnoringASCIICase(input.attributeWithoutSynchronization(typeAttr), InputTypeNames::text()))
+    if (input.isSearchField() || equalIgnoringASCIICase(input.attributeWithoutSynchronization(HTMLNames::typeAttr), InputTypeNames::text()))
         return !input.lastChangeWasUserEdit();
 
@@ -416 +416 @@
                 auto& input = downcast<HTMLInputElement>(currentElement);
                 if (shouldExtractValueForTextManipulation(input))
-                    addItem(ManipulationItemData { { }, { }, makeWeakPtr(currentElement), valueAttr, { ManipulationToken { m_tokenIdentifier.generate(), input.value(), tokenInfo(&currentElement) } } });
+                    addItem(ManipulationItemData { { }, { }, makeWeakPtr(currentElement), HTMLNames::valueAttr, { ManipulationToken { m_tokenIdentifier.generate(), input.value(), tokenInfo(&currentElement) } } });
             }
 
@@ -466 +466 @@
 static const PositionTuple makePositionTuple(const Position& position)
 {
-    return { position.anchorNode(), static_cast<unsigned>(position.anchorType()), position.anchorType() == Position::PositionIsOffsetInAnchor ? position.offsetInContainerNode() : 0 }; 
+    return { position.anchorNode(), static_cast<unsigned>(position.anchorType()), position.anchorType() == Position::PositionIsOffsetInAnchor ? position.offsetInContainerNode() : 0 };
 }
 
@@ -642 +642 @@
         if (item.attributeName == nullQName())
             element->setTextContent(newValue.toString());
-        else if (item.attributeName == valueAttr && is<HTMLInputElement>(*element))
+        else if (item.attributeName == HTMLNames::valueAttr && is<HTMLInputElement>(*element))
             downcast<HTMLInputElement>(*element).setValue(newValue.toString());
         else

trunk/Source/WebCore/platform/graphics/SimpleColor.h

@@ -26 +26 @@
 #pragma once
 
+#include "ColorComponents.h"
 #include "ColorUtilities.h"
+#include <wtf/text/WTFString.h>
 
 namespace WebCore {

trunk/Source/WebCore/workers/service/context/ServiceWorkerThread.cpp

@@ -36 +36 @@
 #include "JSDOMPromise.h"
 #include "LoaderStrategy.h"
+#include "Logging.h"
 #include "PlatformStrategies.h"
 #include "SWContextManager.h"

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-06-05  Adrian Perez de Castro  <aperez@igalia.com>
+
+        Non-unified build fixes, early summer 2020 edition
+        https://bugs.webkit.org/show_bug.cgi?id=212819
+
+        Unreviewed build fix.
+
+        * Shared/gtk/NativeWebMouseEventGtk.cpp:
+        (WebKit::NativeWebMouseEvent::NativeWebMouseEvent): Add missing WebCore:: namespace to
+        a couple of uses of WebCore::FloatSize.
+        * WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp: Add missing Logging.h header.
+
 2020-06-05  Andy Estes  <aestes@apple.com>
 

trunk/Source/WebKit/Shared/gtk/NativeWebMouseEventGtk.cpp

@@ -50 +50 @@
 
 NativeWebMouseEvent::NativeWebMouseEvent(Type type, Button button, unsigned short buttons, const WebCore::IntPoint& position, const WebCore::IntPoint& globalPosition, int clickCount, OptionSet<Modifier> modifiers, Optional<WebCore::FloatSize> delta)
-    : WebMouseEvent(type, button, buttons, position, globalPosition, delta.valueOr(FloatSize()).width(), delta.valueOr(FloatSize()).height(), 0, clickCount, modifiers, WallTime::now())
+    : WebMouseEvent(type, button, buttons, position, globalPosition, delta.valueOr(WebCore::FloatSize()).width(), delta.valueOr(WebCore::FloatSize()).height(), 0, clickCount, modifiers, WallTime::now())
 {
 }

trunk/Source/WebKit/WebProcess/Storage/WebServiceWorkerFetchTaskClient.cpp

@@ -31 +31 @@
 #include "DataReference.h"
 #include "FormDataReference.h"
+#include "Logging.h"
 #include "ServiceWorkerFetchTaskMessages.h"
 #include "SharedBufferDataReference.h"