Changeset 262711 in webkit
- Timestamp:
- Jun 8, 2020 7:24:14 AM (4 years ago)
- Location:
- trunk
- Files:
-
- 2 added
- 3 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/LayoutTests/ChangeLog
r262710 r262711 1 2020-06-08 Antti Koivisto <antti@apple.com> 2 3 Pseudo-elements (::after) in shadow roots don't animate 4 https://bugs.webkit.org/show_bug.cgi?id=173027 5 <rdar://problem/42842994> 6 7 Reviewed by Antoine Quint. 8 9 * animations/keyframe-pseudo-shadow-expected.html: Added. 10 * animations/keyframe-pseudo-shadow.html: Added. 11 1 12 2020-06-08 Youenn Fablet <youenn@apple.com> 2 13 -
trunk/Source/WebCore/ChangeLog
r262710 r262711 1 2020-06-08 Antti Koivisto <antti@apple.com> 2 3 Pseudo-elements (::after) in shadow roots don't animate 4 https://bugs.webkit.org/show_bug.cgi?id=173027 5 <rdar://problem/42842994> 6 7 Reviewed by Antoine Quint. 8 9 Test: animations/keyframe-pseudo-shadow.html 10 11 * animation/AnimationTimeline.cpp: 12 (WebCore::shouldConsiderAnimation): 13 14 We should use the actual element instead of the PseudoElement when calling Style::Scope::forOrdinal. 15 The keyframe code that computes the style already does this correctly. 16 1 17 2020-06-08 Youenn Fablet <youenn@apple.com> 2 18 -
trunk/Source/WebCore/animation/AnimationTimeline.cpp
r262154 r262711 38 38 #include "KeyframeEffect.h" 39 39 #include "KeyframeEffectStack.h" 40 #include "PseudoElement.h" 40 41 #include "RenderStyle.h" 41 42 #include "RenderView.h" … … 211 212 } 212 213 213 static bool shouldConsiderAnimation(Element& element , const Animation& animation)214 static bool shouldConsiderAnimation(Element& elementOrPseudoElement, const Animation& animation) 214 215 { 215 216 if (!animation.isValidAnimation()) … … 221 222 if (name == animationNameNone || name.isEmpty()) 222 223 return false; 224 225 auto& element = is<PseudoElement>(elementOrPseudoElement) ? *downcast<PseudoElement>(elementOrPseudoElement).hostElement() : elementOrPseudoElement; 223 226 224 227 if (auto* styleScope = Style::Scope::forOrdinal(element, animation.nameStyleScopeOrdinal()))
Note: See TracChangeset
for help on using the changeset viewer.