Changeset 262898 in webkit

Timestamp:

Jun 11, 2020 1:09:33 AM (4 years ago)

Author:

svillar@igalia.com

Message:

[WebXR] Pass an unsigned long to cancelAnimationCallback() as handle
​https://bugs.webkit.org/show_bug.cgi?id=212529

Reviewed by Youenn Fablet.

The type of the handle returned by XRSession::requestAnimationFrame() was recently changed
to unsigned long from long as there was no point in using signed integers for that. However
we forgot to update the cancelAnimationFrame() in the specs as well as it receives the handle
returned by requestAnimationFrame().

We landed ​https://github.com/immersive-web/webxr/pull/1069 in the WebXR specs so we can now
safely also replace signed by unsigned integers in our implementation.

No new tests as there is no change in functionality.

Reland r262718.

• Modules/webxr/WebXRSession.cpp:

(WebCore::WebXRSession::cancelAnimationFrame): Use unsigned ids.

• Modules/webxr/WebXRSession.h: Ditto.
• Modules/webxr/WebXRSession.idl: Ditto.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/webxr/WebXRSession.cpp (modified) (1 diff)
• Modules/webxr/WebXRSession.h (modified) (1 diff)
• Modules/webxr/WebXRSession.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-06-10  Sergio Villar Senin  <svillar@igalia.com>
+
+        [WebXR] Pass an unsigned long to cancelAnimationCallback() as handle
+        https://bugs.webkit.org/show_bug.cgi?id=212529
+
+        Reviewed by Youenn Fablet.
+
+        The type of the handle returned by XRSession::requestAnimationFrame() was recently changed
+        to unsigned long from long as there was no point in using signed integers for that. However
+        we forgot to update the cancelAnimationFrame() in the specs as well as it receives the handle
+        returned by requestAnimationFrame().
+
+        We landed https://github.com/immersive-web/webxr/pull/1069 in the WebXR specs so we can now
+        safely also replace signed by unsigned integers in our implementation.
+
+        No new tests as there is no change in functionality.
+
+        Reland r262718.
+
+        * Modules/webxr/WebXRSession.cpp:
+        (WebCore::WebXRSession::cancelAnimationFrame): Use unsigned ids.
+        * Modules/webxr/WebXRSession.h: Ditto.
+        * Modules/webxr/WebXRSession.idl: Ditto.
+
 2020-06-11  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/Modules/webxr/WebXRSession.cpp

@@ -215 +215 @@
 
 // https://immersive-web.github.io/webxr/#dom-xrsession-cancelanimationframe
-void WebXRSession::cancelAnimationFrame(int callbackId)
+void WebXRSession::cancelAnimationFrame(XRFrameRequestCallback::Id callbackId)
 {
     // 1. Let session be the target XRSession object.

trunk/Source/WebCore/Modules/webxr/WebXRSession.h

@@ -75 +75 @@
 
     XRFrameRequestCallback::Id requestAnimationFrame(Ref<XRFrameRequestCallback>&&);
-    void cancelAnimationFrame(int handle);
+    void cancelAnimationFrame(XRFrameRequestCallback::Id handle);
 
     void end(EndPromise&&);

trunk/Source/WebCore/Modules/webxr/WebXRSession.idl

@@ -44 +44 @@
 
     unsigned long requestAnimationFrame(XRFrameRequestCallback callback);
-    void cancelAnimationFrame(long handle);
+    void cancelAnimationFrame(unsigned long handle);
 
     Promise<void> end();