Changeset 263556 in webkit

Timestamp:

Jun 26, 2020 6:36:43 AM (4 years ago)

Author:

aboya@igalia.com

Message:

[GStreamer] Initialize m_currentState and m_oldState
​https://bugs.webkit.org/show_bug.cgi?id=213604

Reviewed by Eric Carlson.

MediaPlayerPrivateGStreamer was not initializing m_currentState and
m_oldState, causing them to be checked e.g. updateStates() while they
still contain garbage.

Because the biggest uninitialized usage is a != comparison, in
practice things still worked, but that's still a bug. I detected the
bug after seeing this in the logs:

playbin3SendSelectStreamsIfAppropriate:<media-player-0> Checking if to send SELECT_STREAMS, m_waitingForStreamsSelectedEvent = false, haveDifferentStreamIds = false, m_currentState = UNKNOWN!(-8421505)... shouldSendSelectStreams = false

This patch fixes a slight memory error which doesn't alter
TestExpectations.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2020-06-26  Alicia Boya García  <aboya@igalia.com>
+
+        [GStreamer] Initialize m_currentState and m_oldState
+        https://bugs.webkit.org/show_bug.cgi?id=213604
+
+        Reviewed by Eric Carlson.
+
+        MediaPlayerPrivateGStreamer was not initializing m_currentState and
+        m_oldState, causing them to be checked e.g. updateStates() while they
+        still contain garbage.
+
+        Because the biggest uninitialized usage is a != comparison, in
+        practice things still worked, but that's still a bug. I detected the
+        bug after seeing this in the logs:
+
+        playbin3SendSelectStreamsIfAppropriate:<media-player-0> Checking if to send SELECT_STREAMS, m_waitingForStreamsSelectedEvent = false, haveDifferentStreamIds = false, m_currentState = UNKNOWN!(-8421505)...  shouldSendSelectStreams = false
+
+        This patch fixes a slight memory error which doesn't alter
+        TestExpectations.
+
+        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
+
 2020-06-25  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h

@@ -342 +342 @@
     bool m_isPaused { true };
     float m_playbackRate { 1 };
-    GstState m_currentState;
-    GstState m_oldState;
+    GstState m_currentState { GST_STATE_NULL };
+    GstState m_oldState { GST_STATE_NULL };
     GstState m_requestedState { GST_STATE_VOID_PENDING };
     bool m_shouldResetPipeline { false };