Changeset 263557 in webkit

Timestamp:

Jun 26, 2020 7:44:38 AM (4 years ago)

Author:

clopez@igalia.com

Message:

generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
​https://bugs.webkit.org/show_bug.cgi?id=213615

Reviewed by Žan Doberšek.

Raise an exception if the parameter passed as remote-config-file is not a file.

• Scripts/generate-jsc-bundle:

(main):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/generate-jsc-bundle (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2020-06-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
+
+        generate-jsc-bundle should fail if passed an invalid remote-config-file parameter
+        https://bugs.webkit.org/show_bug.cgi?id=213615
+
+        Reviewed by Žan Doberšek.
+
+        Raise an exception if the parameter passed as remote-config-file is not a file.
+
+        * Scripts/generate-jsc-bundle:
+        (main):
+
 2020-06-26  Takashi Komori  <takashi.komori@sony.com>
 

trunk/Tools/Scripts/generate-jsc-bundle

@@ -240 +240 @@
     bundleFilePath = createJSCBundle(configuration, options.revision, options.buildername, platform)
     print('Bundle file created at: %s' % bundleFilePath)
-    if options.remoteConfigFile is not None and os.path.isfile(options.remoteConfigFile):
+    if options.remoteConfigFile is not None:
+        if not os.path.isfile(options.remoteConfigFile):
+            raise ValueError("Can't find remote config file for upload at path %s" % options.remoteConfigFile)
         return uploadJSCBundle(bundleFilePath, options.remoteConfigFile, options.configuration, options.revision)
     return 0