Changeset 263601 in webkit


Ignore:
Timestamp:
Jun 26, 2020 4:38:31 PM (4 years ago)
Author:
jer.noble@apple.com
Message:

CRASH: incompatible downcast<> operation in SourceBufferPrivateAVFObjC::setCDMInstance()
​https://bugs.webkit.org/show_bug.cgi?id=213660
<rdar://problem/63831593>

Reviewed by Eric Carlson.

Source/WebCore:

Test: platform/mac/media/encrypted-media/fps-clearkey-crash.html

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::setCDMInstance):

LayoutTests:

  • platform/mac/media/encrypted-media/fps-clearkey-crash-expected.txt: Added.
  • platform/mac/media/encrypted-media/fps-clearkey-crash.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r263598 r263601  
     12020-06-26  Jer Noble  <jer.noble@apple.com>
     2
     3        CRASH: incompatible downcast<> operation in SourceBufferPrivateAVFObjC::setCDMInstance()
     4        https://bugs.webkit.org/show_bug.cgi?id=213660
     5        <rdar://problem/63831593>
     6
     7        Reviewed by Eric Carlson.
     8
     9        * platform/mac/media/encrypted-media/fps-clearkey-crash-expected.txt: Added.
     10        * platform/mac/media/encrypted-media/fps-clearkey-crash.html: Added.
     11
    1122020-06-26  Chris Dumez  <cdumez@apple.com>
    213

  • trunk/Source/WebCore/ChangeLog

    r263597 r263601  
     12020-06-26  Jer Noble  <jer.noble@apple.com>
     2
     3        CRASH: incompatible downcast<> operation in SourceBufferPrivateAVFObjC::setCDMInstance()
     4        https://bugs.webkit.org/show_bug.cgi?id=213660
     5        <rdar://problem/63831593>
     6
     7        Reviewed by Eric Carlson.
     8
     9        Test: platform/mac/media/encrypted-media/fps-clearkey-crash.html
     10
     11        * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
     12        (WebCore::SourceBufferPrivateAVFObjC::setCDMInstance):
     13
    1142020-06-26  Zalan Bujtas  <zalan@apple.com>
    215

  • trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm

    r262687 r263601  
    965965{
    966966#if ENABLE(ENCRYPTED_MEDIA) && HAVE(AVCONTENTKEYSESSION)
    967     auto* fpsInstance = downcast<CDMInstanceFairPlayStreamingAVFObjC>(instance);
     967    auto* fpsInstance = is<CDMInstanceFairPlayStreamingAVFObjC>(instance) ? downcast<CDMInstanceFairPlayStreamingAVFObjC>(instance) : nullptr;
    968968    if (fpsInstance == m_cdmInstance)
    969969        return;
Note: See TracChangeset for help on using the changeset viewer.