Changeset 263607 in webkit

Timestamp:

Jun 26, 2020 6:16:22 PM (4 years ago)

Author:

ddkilzer@apple.com

Message:

Crash at WebKit: 62-[WKContentView(WKInteraction) resignFirstResponderForWebView]_block_invoke
<​https://webkit.org/b/213666>
<rdar://problem/64238661>

Reviewed by Darin Adler.

• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView resignFirstResponderForWebView]):

• Speculative fix to return early if there are no queued key events available by the time the block runs.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/WKContentViewInteraction.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2020-06-26  David Kilzer  <ddkilzer@apple.com>
+
+        Crash at WebKit: __62-[WKContentView(WKInteraction) resignFirstResponderForWebView]_block_invoke
+        <https://webkit.org/b/213666>
+        <rdar://problem/64238661>
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/ios/WKContentViewInteraction.mm:
+        (-[WKContentView resignFirstResponderForWebView]):
+        - Speculative fix to return early if there are no queued key
+          events available by the time the block runs.
+
 2020-06-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm

@@ -1422 +1422 @@
                 if (!page)
                     return;
-                ASSERT(page->hasQueuedKeyEvent());
+                if (!page->hasQueuedKeyEvent())
+                    return;
                 keyEventHandler(page->firstQueuedKeyEvent().nativeEvent(), YES);
             });